From: Anton Eidelman <anton.eidelman@gmail.com>
To: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
sagi@grimberg.me, axboe@fb.com
Subject: Re: [PATCH] nvme/mpath: fix hang when disk goes live over reconnect
Date: Mon, 4 Oct 2021 10:46:12 -0600 [thread overview]
Message-ID: <20211004164612.GA1475751@anton-latitude> (raw)
In-Reply-To: <20210921071527.GA24837@lst.de>
On Tue, Sep 21, 2021 at 09:15:27AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 20, 2021 at 08:53:36AM -0600, Anton Eidelman wrote:
> > The wrapper is to:
> > - follow the naming convention for mpath functions called from core
> > - allow the implementation to have more logic in future
> >
> > As for error propagation, nvme_start_ctrl is void.
>
> Which of course can be changed, like all software.
>
> > Any error in nvme_read_ana_log() will have the same effect as
> > when it is invoked from nvme_ana_work(), i.e. will be ignored.
>
> We need to return negative errors during initialization otherwise
> we're going to run into teardown problems.
How do we proceed with this fix?
I believe error propagation here is not wanted because:
1) A failure to fetch or parse the ANA log should not be considered
an error in ctrl initialization.
2) Such error will not cause problems in teardown.
3) The same failure is possible in ANA work and we do not take
any action in such case.
4) Adding support for failure to nvme_start_ctrl() adds complexity
and does not look useful due to the above 1-3.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-10-04 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 21:57 [PATCH] nvme/mpath: fix hang when disk goes live over reconnect Anton Eidelman
2021-09-19 10:19 ` Sagi Grimberg
2021-09-19 23:05 ` Anton Eidelman
2021-09-20 7:55 ` Sagi Grimberg
2021-09-20 6:35 ` Christoph Hellwig
2021-09-20 14:53 ` Anton Eidelman
2021-09-21 7:15 ` Christoph Hellwig
2021-10-04 16:46 ` Anton Eidelman [this message]
2021-10-04 16:57 ` Christoph Hellwig
2021-10-05 12:38 ` Sagi Grimberg
[not found] ` <368499da-c117-e8b7-7b1b-46894e1e0b48@grimberg.me>
2021-10-19 15:13 ` Anton Eidelman
2022-03-23 3:55 ` [PATCH v2 0/1] " Anton Eidelman
2022-03-23 3:55 ` [PATCH v2 1/1] " Anton Eidelman
2022-03-23 9:23 ` Sagi Grimberg
2022-03-23 14:45 ` [PATCH v3 0/1] " Anton Eidelman
2022-03-23 14:45 ` [PATCH v3 1/1] " Anton Eidelman
2022-03-23 14:55 ` Sagi Grimberg
2022-03-23 15:22 ` Christoph Hellwig
2022-03-24 19:05 ` [PATCH v4 0/1] " Anton Eidelman
2022-03-24 19:05 ` [PATCH v4 1/1] " Anton Eidelman
2022-03-24 21:06 ` Sagi Grimberg
2022-03-25 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004164612.GA1475751@anton-latitude \
--to=anton.eidelman@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).