From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EF59C433FE for ; Tue, 23 Nov 2021 12:38:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=UHcsvYecp75/hq4W/GxZaYVsuQ Ay2K/zznpuJivdx0/p7QEKbaJe3miXJ7fVT9vSR9FmGdJyFNvz2qeecA9nLWFS1ah5cT/D60qusAC +MzsQauboMBblWjufiX0VdKl+1aQ0+KukT7IID6d61w3xK5EPgfAsYSInkKG6yz9lxOnWwoTNX9Py AgH6tQ5ua4A3E1ab42cRRL1T3NyWnOBZxXZeiMqtmjhvUS40axZkhoILrwLgK/0BVsVfNA6TAt62G AFrTJGSUJfPLp4mfxk+RVTCGBzUiH0j7y/wZD/Xt+3PVYlSosCpGA03tFZ1ENhSSqdwiysGYxilir e+zAL7Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpV3z-0028uw-7j; Tue, 23 Nov 2021 12:38:19 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpV3w-0028s7-1m for linux-nvme@lists.infradead.org; Tue, 23 Nov 2021 12:38:17 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3A7AB218F0; Tue, 23 Nov 2021 12:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1637671094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=imV33gbU2ZDoKOMn/DR9MwwGxFf7GryObwVYnFwd4YgcISRncxaHGCUDfmQVShRKifpmM+ /hBGvUxiZvpBx5n6gYAiHbmk2VuorlQHFFgBt+aW9jArc2Muehju4J0JbN3zNVwOju6Eg0 MAzM2Qr+e8C8nEpNSdkRX6vx9iYhkwI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1637671094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=t7kmnBiWnl0n3tjgj0rEe4jxumSxg9E9MKauAGTCmzQrQjYC3kPNlI6+uoSvXKcqhpUQVZ ag6DvmytJ4NzXMCA== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 2C6DFA3B8E; Tue, 23 Nov 2021 12:38:14 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id ADC2551918C6; Tue, 23 Nov 2021 13:38:12 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, Herbert Xu , David Miller , linux-crypto@vger.kernel.org, Hannes Reinecke , Chaitanya Kulkarni , Himanshu Madhani Subject: [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error Date: Tue, 23 Nov 2021 13:37:55 +0100 Message-Id: <20211123123801.73197-7-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211123123801.73197-1-hare@suse.de> References: <20211123123801.73197-1-hare@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_043816_311220_840DFD9F X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: Himanshu Madhani --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index c5a2b71c5268..a1343a0790f6 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n", -- 2.29.2