From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E527C433EF for ; Thu, 3 Feb 2022 16:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z1aQXA/evRaYwVRMnuvjJ7AA/91kOz/SoDK1tejZ25M=; b=QfM9I0esNCpJUyb5X0AkZeUryc AQhfYNxVAvVJy4HxsVJzxDSlXUsJ4l4rPxDIJTomL9lHfGN5NPldvKQrBFTmh5v54ipS8aX3lF/01 5aYEYuGJoUK7TENbuAQDCUMYpb8Ubgu+b7MzlyeUgotMaDIyLHDtXEAWJkePErghDtuGQ4qnoW8A9 vBek7bhkb+6/Rb5pGotAVgRz6Gfhx1A+rNdQJL/Cm4tUDa2RKcjh7zA851xA/bdjBGovgZI/pVarx EHB6ZSeiVEgnn+cqxDSMc7S7cD6+6VUbDu6mNrCg6PhbxjE0VMMpMHWGagBgNk0k6GCdDmmrSn7OU 6s+V/Fsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFelt-001yNL-GN; Thu, 03 Feb 2022 16:15:45 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFelq-001yMK-MV for linux-nvme@lists.infradead.org; Thu, 03 Feb 2022 16:15:44 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8DFEC68AFE; Thu, 3 Feb 2022 17:15:34 +0100 (CET) Date: Thu, 3 Feb 2022 17:15:34 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: Adam Manzanares , Mikulas Patocka , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Chaitanya Kulkarni , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "dm-devel@redhat.com" , "linux-nvme@lists.infradead.org" , linux-fsdevel , Jens Axboe , "msnitzer@redhat.com >> msnitzer@redhat.com" , Bart Van Assche , "martin.petersen@oracle.com >> Martin K. Petersen" , "roland@purestorage.com" , Hannes Reinecke , "kbus @imap.gmail.com>> Keith Busch" , Christoph Hellwig , "Frederick.Knight@netapp.com" , "zach.brown@ni.com" , "osandov@fb.com" , "lsf-pc@lists.linux-foundation.org" , "djwong@kernel.org" , "josef@toxicpanda.com" , "clm@fb.com" , "dsterba@suse.com" , "tytso@mit.edu" , "jack@suse.com" , Kanchan Joshi Subject: Re: [RFC PATCH 3/3] nvme: add the "debug" host driver Message-ID: <20220203161534.GA15366@lst.de> References: <20220201102122.4okwj2gipjbvuyux@mpHalley-2> <20220202060154.GA120951@bgt-140510-bm01> <20220203160633.rdwovqoxlbr3nu5u@garbanzo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203160633.rdwovqoxlbr3nu5u@garbanzo> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220203_081542_930404_EC8EEF08 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Feb 03, 2022 at 08:06:33AM -0800, Luis Chamberlain wrote: > On Wed, Feb 02, 2022 at 06:01:13AM +0000, Adam Manzanares wrote: > > BTW I think having the target code be able to implement simple copy without > > moving data over the fabric would be a great way of showing off the command. > > Do you mean this should be implemented instead as a fabrics backend > instead because fabrics already instantiates and creates a virtual > nvme device? And so this would mean less code? It would be a lot less code. In fact I don't think we need any new code at all. Just using nvme-loop on top of null_blk or brd should be all that is needed.