From: Sagi Grimberg <sagi@grimberg.me>
To: linux-nvme@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH rfc 0/1] nvme-mpath: Add IO stats support
Date: Wed, 28 Sep 2022 22:55:09 +0300 [thread overview]
Message-ID: <20220928195510.165062-1-sagi@grimberg.me> (raw)
I've been hearing complaints about the fact that the nvme mpath stack
device does not expose IO stats just like any normal block device,
instead people need to check the bottom namespaces hidden devices,
mapping back to the mpath device node.
This really sucks, especially for observability hooks/plugins that
I've seen people do.
This is an attempt to make the nvme mpath device expose normal IO stats.
Given that nvme-mpath doesn't have any context after submitting the bio,
we use the core completion path to start/end stats accounting on its
behalf, a similar practice that we use for other multipath related stuff.
Given that its not too invasive, I decided to keep it
in a single patch, but I can certainly split it in to
smaller patches if anyone thinks I should.
Feedback is welcome.
Sagi Grimberg (1):
nvme: support io stats on the mpath device
drivers/nvme/host/apple.c | 2 +-
drivers/nvme/host/core.c | 10 ++++++++++
drivers/nvme/host/fc.c | 2 +-
drivers/nvme/host/multipath.c | 18 ++++++++++++++++++
drivers/nvme/host/nvme.h | 13 +++++++++++++
drivers/nvme/host/pci.c | 2 +-
drivers/nvme/host/rdma.c | 2 +-
drivers/nvme/host/tcp.c | 2 +-
drivers/nvme/target/loop.c | 2 +-
9 files changed, 47 insertions(+), 6 deletions(-)
--
2.34.1
next reply other threads:[~2022-09-28 19:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 19:55 Sagi Grimberg [this message]
2022-09-28 19:55 ` [PATCH rfc] nvme: support io stats on the mpath device Sagi Grimberg
2022-09-29 9:42 ` Max Gurtovoy
2022-09-29 9:59 ` Sagi Grimberg
2022-09-29 10:25 ` Max Gurtovoy
2022-09-29 15:03 ` Keith Busch
2022-09-29 16:14 ` Sagi Grimberg
2022-09-30 15:21 ` Keith Busch
2022-10-03 8:09 ` Sagi Grimberg
2022-10-25 15:30 ` Christoph Hellwig
2022-10-25 15:58 ` Sagi Grimberg
2022-10-30 16:22 ` Christoph Hellwig
2022-09-29 16:32 ` Sagi Grimberg
2022-09-30 15:16 ` Keith Busch
2022-10-03 8:02 ` Sagi Grimberg
2022-10-03 9:32 ` Sagi Grimberg
2022-09-29 15:05 ` Jens Axboe
2022-09-29 16:25 ` Sagi Grimberg
2022-09-30 0:08 ` Jens Axboe
2022-10-03 8:35 ` Sagi Grimberg
2022-09-29 10:04 ` Sagi Grimberg
2022-09-29 15:07 ` Jens Axboe
2022-10-03 8:38 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928195510.165062-1-sagi@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).