From: Jan Kara <jack@suse.cz>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
"Andreas Noever" <andreas.noever@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Borislav Petkov" <bp@alien8.de>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Christoph Hellwig" <hch@lst.de>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Dave Airlie" <airlied@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Florian Westphal" <fw@strlen.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Hugh Dickins" <hughd@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Jan Kara" <jack@suse.com>, "Jason Gunthorpe" <jgg@ziepe.ca>,
"Jens Axboe" <axboe@kernel.dk>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
"KP Singh" <kpsingh@kernel.org>,
"Kees Cook" <keescook@chromium.org>,
"Marco Elver" <elver@google.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Thomas Graf" <tgraf@suug.ch>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Yury Norov" <yury.norov@gmail.com>,
dri-devel@lists.freedesktop.org, kasan-dev@googlegroups.com,
kernel-janitors@vger.kernel.org, linux-block@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org,
linux-mm@kvack.org, linux-mmc@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/5] treewide: use prandom_u32_max() when possible
Date: Thu, 6 Oct 2022 18:24:43 +0200 [thread overview]
Message-ID: <20221006162443.b66waqsxlntfeoek@quack3> (raw)
In-Reply-To: <20221006132510.23374-2-Jason@zx2c4.com>
On Thu 06-10-22 07:25:06, Jason A. Donenfeld wrote:
> Rather than incurring a division or requesting too many random bytes for
> the given range, use the prandom_u32_max() function, which only takes
> the minimum required bytes from the RNG and avoids divisions.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: KP Singh <kpsingh@kernel.org>
> Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
for the ext2, ext4, and lib/sbitmap.c bits.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-10-07 5:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 13:25 [PATCH v2 0/5] treewide cleanup of random integer usage Jason A. Donenfeld
2022-10-06 13:25 ` [PATCH v2 1/5] treewide: use prandom_u32_max() when possible Jason A. Donenfeld
2022-10-06 16:24 ` Jan Kara [this message]
2022-10-06 13:25 ` [PATCH v2 2/5] treewide: use get_random_{u8,u16}() " Jason A. Donenfeld
2022-10-06 13:25 ` [PATCH v2 3/5] treewide: use get_random_u32() " Jason A. Donenfeld
2022-10-06 15:44 ` Chuck Lever III
2022-10-06 16:25 ` Jan Kara
2022-10-06 13:25 ` [PATCH v2 4/5] treewide: use get_random_bytes " Jason A. Donenfeld
2022-10-06 13:25 ` [PATCH v2 5/5] prandom: remove unused functions Jason A. Donenfeld
2022-10-06 13:30 ` [PATCH v2 0/5] treewide cleanup of random integer usage Jason A. Donenfeld
2022-10-06 15:40 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006162443.b66waqsxlntfeoek@quack3 \
--to=jack@suse.cz \
--cc=Jason@zx2c4.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreas.noever@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=christoph.boehmwalder@linbit.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jack@suse.com \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=johannes@sipsolutions.net \
--cc=kadlec@netfilter.org \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=patches@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
--cc=tytso@mit.edu \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).