From: Daniel Wagner <dwagner@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2] nvme-tcp: send quota for nvme_tcp_send_all()
Date: Wed, 26 Oct 2022 10:39:45 +0200 [thread overview]
Message-ID: <20221026083945.dqkhgq4jcbeogngh@carbon.lan> (raw)
In-Reply-To: <202cf139-c8d2-5a55-ed83-d975c136cab2@grimberg.me>
On Wed, Oct 26, 2022 at 11:30:50AM +0300, Sagi Grimberg wrote:
> > Given this, I don't think we currently need to touch this code. Though
> > the unbounded loop makes me a bit uneasy.
>
> This flow only enters when there is a single request queued, so it
> should not be something that takes long. Unless there is a real
> problem, lets not add code that may produce one.
Okay, make sense. I just wonder how to diagnose this scenario.
next prev parent reply other threads:[~2022-10-26 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 15:03 [PATCH v2] nvme-tcp: send quota for nvme_tcp_send_all() Daniel Wagner
2022-10-25 0:54 ` Chaitanya Kulkarni
2022-10-25 5:52 ` Daniel Wagner
2022-10-25 7:09 ` Hannes Reinecke
2022-10-25 13:46 ` Sagi Grimberg
2022-10-26 7:13 ` Daniel Wagner
2022-10-26 8:30 ` Sagi Grimberg
2022-10-26 8:39 ` Daniel Wagner [this message]
2022-10-25 6:37 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026083945.dqkhgq4jcbeogngh@carbon.lan \
--to=dwagner@suse.de \
--cc=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).