From: Daniel Wagner <dwagner@suse.de>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v3 0/4] nvme: add csi, ms and nuse to sysfs
Date: Wed, 6 Dec 2023 09:12:40 +0100 [thread overview]
Message-ID: <20231206081244.32733-1-dwagner@suse.de> (raw)
I'v dropped the RFC status and tested it lot more which found an obvious bug.
When initializating the disk in nvme_alloc_ns, the ns->head pointer was still
NULL. This is why I added the 'nvme: initialize head before namespace' patch.
I can't really explain why my testing didn't catch this earlier. Anyway, I
rebuild my test setup completely to make sure I got the most obvious things
tested. The blktests with loop and nvme-tcp pass, nvme-rdma breaks but so does
the base line test. So not a regression by this series.
Thanks,
Daniel
libnvme changes:
https://github.com/igaw/libnvme/tree/tree-no-cmd
changes:
v3:
- cut overlong lines shorter
- fixed disk (queuedata) initialization order
- more testing with blktest
- added nuse ratelimit
- added reviewed tags
v2:
- moved ns id data to nvme_ns_head
- dropped ds, nsze
- https://lore.kernel.org/linux-nvme/20231201092735.28592-1-dwagner@suse.de/
v1:
- initial version
- https://lore.kernel.org/linux-nvme/20231127103208.25748-1-dwagner@suse.de/
Daniel Wagner (4):
nvme: lookup ctrl from request instead from namespace
nvme: initialize head before namespace
nvme: move ns id info to struct nvme_ns_head
nvme: add csi, ms and nuse to sysfs
drivers/nvme/host/apple.c | 4 +-
drivers/nvme/host/core.c | 279 +++++++++++++++++++--------------
drivers/nvme/host/fc.c | 4 +-
drivers/nvme/host/ioctl.c | 20 +--
drivers/nvme/host/multipath.c | 31 ++--
drivers/nvme/host/nvme.h | 62 ++++----
drivers/nvme/host/rdma.c | 10 +-
drivers/nvme/host/sysfs.c | 31 ++++
drivers/nvme/host/tcp.c | 8 +-
drivers/nvme/host/zns.c | 34 ++--
drivers/nvme/target/loop.c | 4 +-
drivers/nvme/target/passthru.c | 8 +-
12 files changed, 291 insertions(+), 204 deletions(-)
--
2.43.0
next reply other threads:[~2023-12-06 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 8:12 Daniel Wagner [this message]
2023-12-06 8:12 ` [PATCH v3 1/4] nvme: lookup ctrl from request instead from namespace Daniel Wagner
2023-12-06 8:12 ` [PATCH v3 2/4] nvme: initialize head before namespace Daniel Wagner
2023-12-06 8:50 ` Christoph Hellwig
2023-12-06 8:12 ` [PATCH v3 3/4] nvme: move ns id info to struct nvme_ns_head Daniel Wagner
2023-12-06 8:54 ` Christoph Hellwig
2023-12-07 10:53 ` Daniel Wagner
2023-12-06 17:38 ` kernel test robot
2023-12-06 17:38 ` kernel test robot
2023-12-07 5:36 ` Dan Carpenter
2023-12-06 8:12 ` [PATCH v3 4/4] nvme: add csi, ms and nuse to sysfs Daniel Wagner
2023-12-06 8:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206081244.32733-1-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).