linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v1 0/6] nvme-fc: fix blktests nvme/041
Date: Mon, 19 Feb 2024 14:15:25 +0100	[thread overview]
Message-ID: <20240219131531.15134-1-dwagner@suse.de> (raw)

I've dropped the rport ref counting change in the main patch and gave it another
round of testing. This time with dev_loss_tmo active with SCSI and NVME enabled
on the same rport. Nothing exploded, all resources were released correctly.

I am not so happy with the 'connect_sync' name yet (patch #1) but we still have
to agree on that offloading the initial connect attemp is correct. James and
Hannes are strongly in favour for this approach as far I can tell.

changes:
v1:
 - renamed 'nvme-fc: redesign locking and refcounting'
   to 'nvme-fc: reorder ctrl ref counting and cleanup code path'
 - testing with scsi/nvme dev_loss_tmo on real hw
 - removed rport ref counting part
 - collected RB tags
v0:
 - initial version
 - https://lore.kernel.org/linux-nvme/20240216084526.14133-1-dwagner@suse.de/

Daniel Wagner (6):
  nvme-fabrics: introduce connect_sync option
  nvme-fc: rename free_ctrl callback to match name pattern
  nvme-fc: do not retry when auth fails or connection is refused
  nvme-fabrics: introduce ref counting for nvmf_ctrl_options
  nvme-fc: reorder ctrl ref counting and cleanup code path
  nvme-fc: wait for connect attempt to finish

 drivers/nvme/host/fabrics.c |  28 ++++++-
 drivers/nvme/host/fabrics.h |   9 ++-
 drivers/nvme/host/fc.c      | 145 +++++++++++++++++-------------------
 drivers/nvme/host/rdma.c    |  18 +++--
 drivers/nvme/host/tcp.c     |  21 ++++--
 drivers/nvme/target/loop.c  |  19 +++--
 6 files changed, 141 insertions(+), 99 deletions(-)

-- 
2.43.1



             reply	other threads:[~2024-02-19 13:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 13:15 Daniel Wagner [this message]
2024-02-19 13:15 ` [PATCH v1 1/6] nvme-fabrics: introduce connect_sync option Daniel Wagner
2024-02-19 18:44   ` Keith Busch
2024-02-20  5:53     ` Christoph Hellwig
2024-02-19 13:15 ` [PATCH v1 2/6] nvme-fc: rename free_ctrl callback to match name pattern Daniel Wagner
2024-02-19 13:15 ` [PATCH v1 3/6] nvme-fc: do not retry when auth fails or connection is refused Daniel Wagner
2024-02-19 13:15 ` [PATCH v1 4/6] nvme-fabrics: introduce ref counting for nvmf_ctrl_options Daniel Wagner
2024-02-19 13:15 ` [PATCH v1 5/6] nvme-fc: reorder ctrl ref counting and cleanup code path Daniel Wagner
2024-02-19 13:15 ` [PATCH v1 6/6] nvme-fc: wait for connect attempt to finish Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240219131531.15134-1-dwagner@suse.de \
    --to=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).