From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0 1/6] nvme-fabrics: introduce connect_sync option
Date: Tue, 20 Feb 2024 07:51:31 +0100 [thread overview]
Message-ID: <20240220065131.GA9150@lst.de> (raw)
In-Reply-To: <jfjchxptpfcpolpy2etiigflqvfcp2nzk53iwb6rx2zsdfd6by@h6ezfayjfqai>
On Fri, Feb 16, 2024 at 05:44:02PM +0100, Daniel Wagner wrote:
> James answered this point on my attempt to make this synchronous:
>
> https://lore.kernel.org/linux-nvme/0605ac36-16d5-2026-d3c6-62d346db6dfb@gmail.com/
That needs to go into the commit log. And I call complete BS on that
to be honest.
> Ideally, we could agree on behavior which is the same for all
> transports.
sync and async opt in it is. I'm still pissed FC did this differently
without any proper discussion of the tradeoffs.
next prev parent reply other threads:[~2024-02-20 6:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 8:45 [PATCH v0 0/6] nvme-fc: fix blktests nvme/041 Daniel Wagner
2024-02-16 8:45 ` [PATCH v0 1/6] nvme-fabrics: introduce connect_sync option Daniel Wagner
2024-02-16 9:49 ` Christoph Hellwig
2024-02-16 16:44 ` Daniel Wagner
2024-02-20 6:51 ` Christoph Hellwig [this message]
2024-02-17 16:27 ` Hannes Reinecke
2024-02-16 8:45 ` [PATCH v0 2/6] nvme-fc: rename free_ctrl callback to match name pattern Daniel Wagner
2024-02-16 9:49 ` Christoph Hellwig
2024-02-16 8:45 ` [PATCH v0 3/6] nvme-fc: do not retry when auth fails or connection is refused Daniel Wagner
2024-02-16 9:49 ` Christoph Hellwig
2024-02-16 8:45 ` [PATCH v0 4/6] nvme-fabrics: introduce ref counting for nvmf_ctrl_options Daniel Wagner
2024-02-16 9:50 ` Christoph Hellwig
2024-02-16 8:45 ` [PATCH v0 5/6] nvme-fc: redesign locking and refcounting Daniel Wagner
2024-02-16 9:51 ` Christoph Hellwig
2024-02-16 11:09 ` Hannes Reinecke
2024-02-16 12:40 ` Daniel Wagner
2024-02-16 8:45 ` [PATCH v0 6/6] nvme-fc: wait for connect attempt to finish Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220065131.GA9150@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).