linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@wdc.com>, Hannes Reinecke <hare@suse.de>,
	linux-nvme@lists.infradead.org,
	James Smart <jsmart2021@gmail.com>,
	Chao Leng <lengchao@huawei.com>
Subject: Re: [PATCH v2 1/2] nvme-tcp: short-circuit reconnect retries
Date: Tue, 5 Mar 2024 14:49:30 +0100	[thread overview]
Message-ID: <20240305134930.GB2063@lst.de> (raw)
In-Reply-To: <20240304161006.19328-2-dwagner@suse.de>

> +	bool recon = status > 0 && (status & NVME_SC_DNR) ? false : true;

This is screaming for a (well-documented) helper.



  reply	other threads:[~2024-03-05 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 16:10 [PATCH v2 0/2] nvme-fabrics: short-circuit connect retries Daniel Wagner
2024-03-04 16:10 ` [PATCH v2 1/2] nvme-tcp: short-circuit reconnect retries Daniel Wagner
2024-03-05 13:49   ` Christoph Hellwig [this message]
2024-03-04 16:10 ` [PATCH v2 2/2] nvme-rdma: " Daniel Wagner
2024-03-04 16:32 ` [PATCH v2 0/2] nvme-fabrics: short-circuit connect retries Keith Busch
2024-03-05  7:21   ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305134930.GB2063@lst.de \
    --to=hch@lst.de \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=jsmart2021@gmail.com \
    --cc=keith.busch@wdc.com \
    --cc=lengchao@huawei.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).