linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Gopal Tiwari <gtiwari@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: kbusch@kernel.org, hch@lst.de, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-pci: prevent SK Hynix PE8000 from using Write Zeroes command
Date: Wed, 10 Feb 2021 06:17:23 -0500 (EST)	[thread overview]
Message-ID: <211078952.30654328.1612955843198.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <YCOxjZhBTBchOq0n@infradead.org>

Hi Christoph, 

Thanks for the response,

----- Original Message -----
From: "Christoph Hellwig" <hch@infradead.org>
To: "Gopal Tiwari" <gtiwari@redhat.com>
Cc: kbusch@kernel.org, hch@lst.de, linux-nvme@lists.infradead.org
Sent: Wednesday, February 10, 2021 3:42:29 PM
Subject: Re: [PATCH] nvme-pci: prevent SK Hynix PE8000 from using Write Zeroes command

On Tue, Feb 09, 2021 at 10:29:02AM +0530, Gopal Tiwari wrote:
>> For SK Hynix PE8000 WriteZerocommands exceed typical I/O MDTS
>> (Maximum Data Transfer Size) supported by the hardware. Which
>> intern fail and generate following erros :

>Well, if it works under MDTS please add a new quirk that follows
MDTS for Write Zeroes.

This was the feedback from the hardware guys, We've not tried, as the safe option would be to disable 
write zero's as spec says 

I could see from the identify controller details 

  [0:0] : 0	Single Port

mdts      : 7 <<---------- 
cntlid    : 0
ver       : 0x10300

"This field does not apply to commands that do not transfer
data between host-accessible memory and the controller (e.g., the Verify command,
the Write Uncorrectable command, and the Write Zeroes command); there is no
maximum data transfer size for those commands. "

>  In fact I wonder if we should just do that by default to be on the safe side.
Can you please help me in understanding this ..  

Thanks & regards,
Gopal Tiwari 

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-02-10 11:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09  4:59 [PATCH] nvme-pci: prevent SK Hynix PE8000 from using Write Zeroes command Gopal Tiwari
2021-02-09  5:38 ` Chaitanya Kulkarni
2021-02-09  5:59   ` Gopal Tiwari
2021-02-10 10:12 ` Christoph Hellwig
2021-02-10 11:17   ` Gopal Tiwari [this message]
2021-02-10 13:15     ` Christoph Hellwig
2021-02-10 22:11       ` Chaitanya Kulkarni
2021-02-11  7:07         ` Christoph Hellwig
2021-02-11 18:11           ` Chaitanya Kulkarni
2021-02-24  9:13             ` Christoph Hellwig
2021-02-25  2:09               ` Chaitanya Kulkarni
2021-02-25  7:56                 ` Gopal Tiwari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=211078952.30654328.1612955843198.JavaMail.zimbra@redhat.com \
    --to=gtiwari@redhat.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).