linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: Christoph Hellwig <hch@infradead.org>, amit.engel@dell.com
Cc: linux-nvme@lists.infradead.org, james.smart@broadcom.com,
	Chaitanya.Kulkarni@wdc.com
Subject: Re: [PATCH] nvmet-fc: simplify nvmet_fc_alloc_hostport
Date: Sat, 10 Apr 2021 07:27:04 -0700	[thread overview]
Message-ID: <22529f8d-dcba-e7c5-e6da-d1430134d770@gmail.com> (raw)
In-Reply-To: <20210410064556.GB335861@infradead.org>

On 4/9/2021 11:45 PM, Christoph Hellwig wrote:
> On Mon, Mar 22, 2021 at 09:57:17PM +0200, amit.engel@dell.com wrote:
>> From: Amit Engel <amit.engel@dell.com>
>>
>> Once a host is already created,
>> avoid allocate additional hostports that will be thrown away.
>> add an helper function to handle host search.
>>
>> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
>> Signed-off-by: James Smart <jsmart2021@gmail.com>
> 
> Is this really a signoff from James or a review?
> 

I reworked some of it - so it's a joint Signed-off-by w/ Amit.

-- james


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-04-10 14:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 19:57 [PATCH] nvmet-fc: simplify nvmet_fc_alloc_hostport amit.engel
2021-03-26 13:32 ` Engel, Amit
2021-03-26 19:02   ` Chaitanya Kulkarni
2021-04-04 11:41     ` Engel, Amit
2021-04-10  6:45 ` Christoph Hellwig
2021-04-10 14:27   ` James Smart [this message]
2021-04-12  7:48 ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2021-03-22 18:59 amit.engel
2021-03-22 19:11 ` Chaitanya Kulkarni
2021-03-22 19:13 ` Chaitanya Kulkarni
2021-03-22 19:15 ` Chaitanya Kulkarni
2021-03-22 19:37   ` James Smart
2021-03-22 19:40     ` Chaitanya Kulkarni
2021-03-16  6:43 amit.engel
2021-03-17 21:28 ` Himanshu Madhani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22529f8d-dcba-e7c5-e6da-d1430134d770@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=amit.engel@dell.com \
    --cc=hch@infradead.org \
    --cc=james.smart@broadcom.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).