From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097BBC43331 for ; Tue, 12 Nov 2019 18:35:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE19C214E0 for ; Tue, 12 Nov 2019 18:35:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MtfRzMKW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE19C214E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZPCV2AVX+b1xiwPfX/HgkeJq55WLDV3ptqmolmSpsyA=; b=MtfRzMKWEZYRA79FZ3rzNpo26 8YUjrPXKtnJqJEibm9SC9RvyZ1j8pFPgDlxKkSglFJn9S+TAGJsQ4pwS0w/miNbSjmezYjQXAEhbM ECEBOpHa58qKwOcfqizeQH8yb6iGrjpMEvcfZw5EqiVKOJfL3bqGLVdkWDT6WustEBs5sy9uuBDAj 0RbREm9WPaHdqxpyf5R/yFin2gatT1urV2lTphJRJ2XQM6dKHO7C7ujT/tXMnP1LZxqz1RSXQ3+Rj BaVczY1XednqkldRNYm9ln4rFPPX88hxI4hDL1PSQork4r01RpqJryucoerwcbgCsCqmfsZkySzkj k1awM1L5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUb0a-0001ix-0e; Tue, 12 Nov 2019 18:35:20 +0000 Received: from mail-ot1-f54.google.com ([209.85.210.54]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUb0K-0000Yk-JX for linux-nvme@lists.infradead.org; Tue, 12 Nov 2019 18:35:06 +0000 Received: by mail-ot1-f54.google.com with SMTP id m15so15189492otq.7 for ; Tue, 12 Nov 2019 10:35:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VpTUgkOXAU+Nv6gPqXh+VMnQ/kTwIi1avxw5bhq1shI=; b=iMhf/Kjv+keM09t0m9tEtnEcP36WxipGMeBDOUmsm5bz5tuc/rJR8agXi7XxvyfHNk DXPNZrbNsizGeNMi+T1BnjSa2RZ/h6G8TOb3jpcsFV0D8eL0oKHcFWKCboaNxJoP3lbJ eLZ+1CeVBB8z1FYa/HQLIv4FjXnQX/qVhkSDkUmFQDFVCWnIZLbA0K/kDT+JtNaJngP4 /MHRvFlDi2DGQ2dtQDgSql6iZ8bdeEIOZvc4G0QogiXIoAAZHXFWGa4DQvP0G2XdbdpO 6Dcry8vSeWtieemsVjbcOTUru+gDdTHd9e6tl1kgDNH0iZgAGlei5QlkvejjgXO7RmvF A6nA== X-Gm-Message-State: APjAAAXtIG3wlduPHqJoF4QRLTsOfdCEFWx8mxjmErT3+Pvk1Qibzy1a 4hHIgY+46QTf2H8dmrEof9M= X-Google-Smtp-Source: APXvYqyLE2bKv9hVZEA3wYK5YbaCOkaKa1sePVDhboAw1mPZZdPgcxHk/RJuhfOhyLN0IQysfTgj/A== X-Received: by 2002:a9d:4616:: with SMTP id y22mr25708394ote.319.1573583703163; Tue, 12 Nov 2019 10:35:03 -0800 (PST) Received: from [192.168.1.114] (162-195-240-247.lightspeed.sntcca.sbcglobal.net. [162.195.240.247]) by smtp.gmail.com with ESMTPSA id o22sm6022437otk.47.2019.11.12.10.35.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Nov 2019 10:35:02 -0800 (PST) Subject: Re: [PATCH 15/15] nvmet-rdma: Add metadata/T10-PI support To: Max Gurtovoy , linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de References: <20191105162026.183901-1-maxg@mellanox.com> <20191105162026.183901-17-maxg@mellanox.com> From: Sagi Grimberg Message-ID: <24d8febb-7ddd-3461-dd60-aa73b1d58f1c@grimberg.me> Date: Tue, 12 Nov 2019 10:34:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191105162026.183901-17-maxg@mellanox.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_103504_644408_1DB77D12 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: israelr@mellanox.com, oren@mellanox.com, idanb@mellanox.com, vladimirk@mellanox.com, shlomin@mellanox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > + if (ndev->pi_capable && nvmet_rdma_pi_enable && queue->host_qid) > + qp_attr.create_flags |= IB_QP_CREATE_INTEGRITY_EN; > + Max, It will really be much better if this comes in the rdma_cm private_data... Have you considered to get this trhough the TWG? > ret = rdma_create_qp(queue->cm_id, ndev->pd, &qp_attr); > if (ret) { > pr_err("failed to create_qp ret= %d\n", ret); > _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme