From: Max Gurtovoy <maxg@mellanox.com> To: Christoph Hellwig <hch@lst.de> Cc: sagi@grimberg.me, vladimirk@mellanox.com, idanb@mellanox.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, shlomin@mellanox.com, oren@mellanox.com, kbusch@kernel.org Subject: Re: [PATCH 15/15] nvmet-rdma: Add metadata/T10-PI support Date: Thu, 7 Nov 2019 15:43:56 +0200 Message-ID: <3069d77c-01ae-4d4c-1b96-a785dbfd26d9@mellanox.com> (raw) In-Reply-To: <20191105180254.GJ18972@lst.de> On 11/5/2019 8:02 PM, Christoph Hellwig wrote: >> +static bool nvmet_rdma_pi_enable; >> +module_param_named(pi_enable, nvmet_rdma_pi_enable, bool, 0444); >> +MODULE_PARM_DESC(pi_enable, "Enable metadata (T10-PI) support"); > This needs to be a configfs attribute, not a module parameter. Ok, we'll move it to be per port configuration. > >> + /* Data Out / RDMA WRITE */ >> + r->write_cqe.done = nvmet_rdma_write_data_done; >> + > We should only do that for actual PI enabled controllers. Also please are you talking about the assignment ? I guess we can add an "if" check. > use IS_ENABLED or ifdef to only compile this code if we actually support > PI in the kernel build. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply index Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 16:20 [PATCH 00/15] nvme-rdma/nvmet-rdma: " Max Gurtovoy 2019-11-05 16:20 ` [PATCH] nvme-cli/fabrics: Add pi_enable param to connect cmd Max Gurtovoy 2019-11-07 2:36 ` Martin K. Petersen 2019-11-07 12:02 ` Max Gurtovoy 2019-11-09 1:55 ` Martin K. Petersen 2019-11-10 9:25 ` Max Gurtovoy 2019-11-12 17:47 ` Sagi Grimberg 2019-11-12 18:14 ` James Smart 2019-11-12 18:23 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 01/15] nvme-fabrics: allow user enabling metadata/T10-PI support Max Gurtovoy 2019-11-12 17:48 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 02/15] nvme: Fail __nvme_revalidate_disk in case of a spec violation Max Gurtovoy 2019-11-05 17:49 ` Christoph Hellwig 2019-11-12 17:52 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 03/15] nvme: Introduce max_integrity_segments ctrl attribute Max Gurtovoy 2019-11-05 17:49 ` Christoph Hellwig 2019-11-12 17:53 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 04/15] nvme: Inline nvme_ns_has_pi function Max Gurtovoy 2019-11-05 17:50 ` Christoph Hellwig 2019-11-05 16:20 ` [PATCH 05/15] nvme-rdma: Add metadata/T10-PI support Max Gurtovoy 2019-11-05 17:58 ` Christoph Hellwig 2019-11-20 10:41 ` Max Gurtovoy 2019-11-12 18:22 ` Sagi Grimberg 2019-11-13 14:35 ` Max Gurtovoy 2019-11-14 23:57 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 06/15] block: Introduce BIP_NOMAP_INTEGRITY bip_flag Max Gurtovoy 2019-11-05 17:52 ` Christoph Hellwig 2019-11-07 2:43 ` Martin K. Petersen 2019-11-07 13:29 ` Max Gurtovoy 2019-11-09 2:10 ` Martin K. Petersen 2019-11-12 10:40 ` Max Gurtovoy 2019-11-05 16:20 ` [PATCH 07/15] nvmet: Prepare metadata request Max Gurtovoy 2019-11-05 16:20 ` [PATCH 08/15] nvmet: Add metadata characteristics for a namespace Max Gurtovoy 2019-11-05 17:59 ` Christoph Hellwig 2019-11-12 18:38 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 09/15] nvmet: Rename nvmet_rw_len to nvmet_rw_data_len Max Gurtovoy 2019-11-05 17:59 ` Christoph Hellwig 2019-11-12 18:39 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 10/15] nvmet: Rename nvmet_check_data_len to nvmet_check_transfer_len Max Gurtovoy 2019-11-05 18:00 ` Christoph Hellwig 2019-11-12 18:43 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 11/15] nvmet: Introduce nvmet_rw_prot_len and nvmet_ns_has_pi Max Gurtovoy 2019-11-05 18:00 ` Christoph Hellwig 2019-11-05 16:20 ` [PATCH 12/15] nvme: Add Metadata Capabilities enumerations Max Gurtovoy 2019-11-05 16:20 ` [PATCH 13/15] nvmet: Add metadata/T10-PI support Max Gurtovoy 2019-11-05 16:20 ` [PATCH 14/15] nvmet: Add metadata support for block devices Max Gurtovoy 2019-11-05 16:20 ` [PATCH 15/15] nvmet-rdma: Add metadata/T10-PI support Max Gurtovoy 2019-11-05 18:02 ` Christoph Hellwig 2019-11-07 13:43 ` Max Gurtovoy [this message] 2019-11-12 18:34 ` Sagi Grimberg 2019-11-13 13:56 ` Max Gurtovoy 2019-11-14 23:45 ` Sagi Grimberg 2020-01-06 13:37 [PATCH 00/15 V3] nvme-rdma/nvmet-rdma: " Max Gurtovoy 2020-01-06 13:37 ` [PATCH 15/15] nvmet-rdma: " Max Gurtovoy 2020-01-09 3:29 ` Martin K. Petersen 2020-04-28 13:11 [PATCH 00/15 V6] nvme-rdma/nvmet-rdma: " Max Gurtovoy 2020-04-28 13:11 ` [PATCH 15/15] nvmet-rdma: add " Max Gurtovoy 2020-05-01 16:48 ` Christoph Hellwig 2020-05-03 16:29 ` Max Gurtovoy 2020-05-04 14:08 ` Christoph Hellwig 2020-05-04 14:19 ` Max Gurtovoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3069d77c-01ae-4d4c-1b96-a785dbfd26d9@mellanox.com \ --to=maxg@mellanox.com \ --cc=hch@lst.de \ --cc=idanb@mellanox.com \ --cc=israelr@mellanox.com \ --cc=kbusch@kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=oren@mellanox.com \ --cc=sagi@grimberg.me \ --cc=shlomin@mellanox.com \ --cc=vladimirk@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-NVME Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \ linux-nvme@lists.infradead.org public-inbox-index linux-nvme Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme AGPL code for this site: git clone https://public-inbox.org/public-inbox.git