From: Sagi Grimberg <sagi@grimberg.me>
To: James Smart <james.smart@broadcom.com>,
Edmund Nadolski <edmund.nadolski@intel.com>,
linux-nvme@lists.infradead.org, keith.busch@intel.com
Subject: Re: [PATCH] nvme: include admin_q sync with nvme_sync_queues
Date: Wed, 4 Sep 2019 19:28:42 -0700 [thread overview]
Message-ID: <4753c18d-1122-20e0-d3d1-64745018078d@grimberg.me> (raw)
In-Reply-To: <72e9ffb3-fdad-5624-12d5-b1fd38258413@broadcom.com>
> On 9/3/2019 1:08 PM, Edmund Nadolski wrote:
>> nvme_sync_queues currently syncs all namespace queues, but should
>> also sync the admin queue, if present.
>>
>> Signed-off-by: Edmund Nadolski <edmund.nadolski@intel.com>
>> ---
>> drivers/nvme/host/core.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 4660505eded9..43c12f8c030f 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -3974,6 +3974,9 @@ void nvme_sync_queues(struct nvme_ctrl *ctrl)
>> list_for_each_entry(ns, &ctrl->namespaces, list)
>> blk_sync_queue(ns->queue);
>> up_read(&ctrl->namespaces_rwsem);
>> +
>> + if (ctrl->admin_q)
>> + blk_sync_queue(ctrl->admin_q);
>> }
>> EXPORT_SYMBOL_GPL(nvme_sync_queues);
> which probably mean the new request_q should be there too....
Given that only pci uses it I think we don't need it for now...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-05 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 20:08 [PATCH] nvme: include admin_q sync with nvme_sync_queues Edmund Nadolski
2019-09-03 20:12 ` Keith Busch
2019-09-03 20:22 ` James Smart
2019-09-05 2:28 ` Sagi Grimberg [this message]
2019-09-04 12:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4753c18d-1122-20e0-d3d1-64745018078d@grimberg.me \
--to=sagi@grimberg.me \
--cc=edmund.nadolski@intel.com \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).