From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94804C433EF for ; Mon, 13 Sep 2021 09:28:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 669ED60D42 for ; Mon, 13 Sep 2021 09:28:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 669ED60D42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sqMY/uLwti4ABLv8G8MnR9BF4+mMl1zl5WdtuJX5qBo=; b=Z5cwNWwfpEW2ZXerm0iIIxpR0h 2FQpnq0Tn8bzK3QwuS3jJWCMLS/zcD14rRwIajDhqFHTTPeo1cEtlXKeh1/dSJ51f2SUfbcge9Rr8 TskSTNhJCFBvEioRKvmO+1IwCuXCvd8EKiboT3hqH4NeeM636NvQq3fZXFNd/dt+RQJKLO0s9kBPE i775qcdQX/B7koju3Xhr78QIB5v0PwV1GmxtdE17uFSMNCtoz2lsq9oueS7ciFz1yOG7ntkyO7un/ kb2DoicvEO6YQBiOVLb4zsRyjrQUEQCmJO8qe2sQsiufJW0EVEfD2NZy1jE5M68R2Tbt8PD9zO+eP n4AOEceA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPiFa-0013f3-P4; Mon, 13 Sep 2021 09:27:42 +0000 Received: from mail-wm1-f47.google.com ([209.85.128.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPi4L-0010Od-Bc for linux-nvme@lists.infradead.org; Mon, 13 Sep 2021 09:16:06 +0000 Received: by mail-wm1-f47.google.com with SMTP id k5-20020a05600c1c8500b002f76c42214bso6365686wms.3 for ; Mon, 13 Sep 2021 02:16:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UlWb7GG9KmgW1uBK20hHYqN4Cy+L80BmV4mPEcAhQv8=; b=VpBjz+r+gW3Hn4skxHAUrXtcWJTtttqcQTbfB+XhGFTFIEoOwoVqbXli/y0y6JS4sQ h8034H5DmMQrp/Z7//a8mJgeT3iizaNv6QgQnGz1EIZg4M1Y5kipvJlbdsPygnyrjSA3 0AgLmH9FCCRdSBHeOs3mNtlkCRFq5dVtEdGaVuGpS39p3/U+Mi15E34braMYW8wCJLi/ HRbV0IXgBguV+edNOwRtePt0DskesRZMqJ+zNPdVB+6EWNKVmhGWXdfHLVV8H85BFXbo CNH0/+bTfzB68D2ngLqX6o6x9JlEMxGJMH7LdWEN/aJgh9hOiPE3ovFmT3Sm9O0v3DlC YiKw== X-Gm-Message-State: AOAM533/1zwR/3/uvDrdTnCN5RjfVeHKntvR8FPCjDYURfHrYbtwHb/m BGEm9CLZZQ4gTI7VPrwFNIw= X-Google-Smtp-Source: ABdhPJz2+/ks0/io8Q8QcVIq/Dm/v+sGRIKkMWLyJ6HGuPjRmIX+l3rZvmMIfXN2VK0XvqkJS0hs5Q== X-Received: by 2002:a7b:c0c7:: with SMTP id s7mr10129533wmh.66.1631524564128; Mon, 13 Sep 2021 02:16:04 -0700 (PDT) Received: from [192.168.64.123] (bzq-219-42-90.isdn.bezeqint.net. [62.219.42.90]) by smtp.gmail.com with ESMTPSA id u13sm5830705wmq.33.2021.09.13.02.16.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 02:16:03 -0700 (PDT) Subject: Re: [PATCHv3 00/12] nvme: In-band authentication support To: Hannes Reinecke , Christoph Hellwig Cc: Keith Busch , Herbert Xu , "David S . Miller" , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org References: <20210910064322.67705-1-hare@suse.de> From: Sagi Grimberg Message-ID: <47a839c3-1c8d-9ccf-3b3d-387862227c4f@grimberg.me> Date: Mon, 13 Sep 2021 12:16:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910064322.67705-1-hare@suse.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_021605_475572_0BB3A50C X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > Hi all, > > recent updates to the NVMe spec have added definitions for in-band > authentication, and seeing that it provides some real benefit > especially for NVMe-TCP here's an attempt to implement it. > > Tricky bit here is that the specification orients itself on TLS 1.3, > but supports only the FFDHE groups. Which of course the kernel doesn't > support. I've been able to come up with a patch for this, but as this > is my first attempt to fix anything in the crypto area I would invite > people more familiar with these matters to have a look. > > Also note that this is just for in-band authentication. Secure > concatenation (ie starting TLS with the negotiated parameters) is not > implemented; one would need to update the kernel TLS implementation > for this, which at this time is beyond scope. > > As usual, comments and reviews are welcome. Still no nvme-cli nor nvmetcli :( _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme