linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [RFC PATCH 01/21] block: add and use init tagset helper
Date: Thu, 6 Oct 2022 11:40:29 -0700	[thread overview]
Message-ID: <51f62009-777f-8958-8d28-b29e64bbff09@acm.org> (raw)
In-Reply-To: <7e9ce6b2-70c8-cf85-95ab-de09090db64d@nvidia.com>

On 10/6/22 11:13, Chaitanya Kulkarni wrote:
> I will trim down the argument list with the most common arguments
> and keep it to max 4-5 mandatory arguments identical to what we
> have done this for blk_next_bio() and bio_alloc_bioset() [1]
> where mandatory arguments are part of the initialization API
> than repeating the code all the in the tree, that creates
> maintenance work of treewide patches.
> 
> Also, instead of doing tree wide change in series I'll start small
> and gradually add more patches over time.
> 
> This definitely adds a more value to the code where code is not
> repeated for mandatory arguments, which are way less than 9.

Hmm ... I'm not convinced that the approach outlined above will result
in a valuable patch series. I think my objections also apply to the
approach outlined above.

Bart.


  reply	other threads:[~2022-10-06 18:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05  3:22 [RFC PATCH 00/21] block: add and use init tagset helper Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 01/21] " Chaitanya Kulkarni
2022-10-05  5:11   ` Damien Le Moal
2022-10-05  9:47     ` Ulf Hansson
2022-10-05 16:54       ` Bart Van Assche
2022-10-05 17:22         ` Chaitanya Kulkarni
2022-10-06 18:13           ` Chaitanya Kulkarni
2022-10-06 18:40             ` Bart Van Assche [this message]
2022-10-07 19:40               ` Jens Axboe
2022-10-05  3:22 ` [RFC PATCH 02/21] loop: use lib tagset init helper Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 03/21] nbd: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 04/21] rnbd: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 05/21] bsg-lib: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 06/21] rnbd-clt: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 07/21] virtio-blk: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 08/21] scsi: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 09/21] block: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 10/21] amiflop: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 11/21] floppy: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 12/21] mtip32xx: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 13/21] z3ram: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 14/21] scm_blk: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 15/21] ubi: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 16/21] mmc: core: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 17/21] dasd: " Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 18/21] nvme-core: use lib tagset init helper for I/O q Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 19/21] nvme-core: use lib tagset init helper for adminq Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 20/21] nvme-apple: use lib tagset init helper Chaitanya Kulkarni
2022-10-05  3:22 ` [RFC PATCH 21/21] nvme-pci: " Chaitanya Kulkarni
2022-10-07 18:26 ` [RFC PATCH 00/21] block: add and use init tagset helper Luis Chamberlain
2022-10-10  7:55   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51f62009-777f-8958-8d28-b29e64bbff09@acm.org \
    --to=bvanassche@acm.org \
    --cc=chaitanyak@nvidia.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).