From: Sagi Grimberg <sagi@grimberg.me>
To: "Wunderlich, Mark" <mark.wunderlich@intel.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: Sighting: Kernel fault with large write (512k) and io_uring
Date: Mon, 23 Mar 2020 14:18:32 -0700 [thread overview]
Message-ID: <52ce2f94-e11b-c537-63d2-e9b72cf1b00c@grimberg.me> (raw)
In-Reply-To: <82255be7-fb89-c66c-442e-6fe04239768c@grimberg.me>
>>> Can you run:
>>> gdb drivers/nvme/host/nvme-tcp.ko
>>> ...
>>> $ l *(nvme_tcp_try_recv+0x59)
>>
>> (gdb) L *(nvme_tcp_try_recv+0x59)
>> 0xffffffffc03d04d9 is in nvme_tcp_try_recv
>> (drivers/nvme/host/tcp.c:1046).
>> 1041
>> 1042 rd_desc.arg.data = queue;
>> 1043 rd_desc.count = 1;
>> 1044 lock_sock(sk);
>> 1045 queue->nr_cqe = 0;
>> 1046 consumed = sock->ops->read_sock(sk, &rd_desc,
>> nvme_tcp_recv_skb);
>> 1047 release_sock(sk);
>> 1048 return consumed;
>> 1049 }
>> 1050
>> Reproduced this fault on branch nvme-5.6-rc6.
Mark, does this patch make the issue go away?
--
@@ -2326,6 +2328,9 @@ static int nvme_tcp_poll(struct blk_mq_hw_ctx *hctx)
struct nvme_tcp_queue *queue = hctx->driver_data;
struct sock *sk = queue->sock->sk;
+ if (!test_bit(NVME_TCP_Q_LIVE, &queue->flags))
+ return 0;
+
set_bit(NVME_TCP_Q_POLLING, &queue->flags);
if (sk_can_busy_loop(sk) &&
skb_queue_empty_lockless(&sk->sk_receive_queue))
sk_busy_loop(sk, true);
--
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-23 21:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 23:37 Sighting: Kernel fault with large write (512k) and io_uring Wunderlich, Mark
2020-03-19 1:12 ` Sagi Grimberg
2020-03-19 2:33 ` Jens Axboe
2020-03-23 21:07 ` Wunderlich, Mark
2020-03-23 21:11 ` Sagi Grimberg
2020-03-23 21:18 ` Sagi Grimberg [this message]
2020-03-23 22:04 ` Wunderlich, Mark
2020-03-23 22:09 ` Sagi Grimberg
2020-03-23 23:16 ` Wunderlich, Mark
2020-03-23 23:29 ` Sagi Grimberg
2020-03-23 23:45 ` Wunderlich, Mark
2020-03-23 23:48 ` Sagi Grimberg
2020-03-24 0:34 ` Wunderlich, Mark
2020-03-24 1:29 ` Sagi Grimberg
2020-03-24 16:31 ` Wunderlich, Mark
2020-03-24 19:13 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ce2f94-e11b-c537-63d2-e9b72cf1b00c@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=linux-nvme@lists.infradead.org \
--cc=mark.wunderlich@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).