From: Hannes Reinecke <hare@suse.de>
To: Muneendra <muneendra.kumar@broadcom.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, linux-nvme@lists.infradead.org
Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com,
Gaurav Srivastava <gaurav.srivastava@broadcom.com>
Subject: Re: [PATCH v8 10/16] lpfc: vmid: Functions to manage vmids
Date: Thu, 4 Mar 2021 13:41:47 +0100 [thread overview]
Message-ID: <57930010-ab0a-0d95-210b-3b578fd649ff@suse.de> (raw)
In-Reply-To: <1614835646-16217-11-git-send-email-muneendra.kumar@broadcom.com>
On 3/4/21 6:27 AM, Muneendra wrote:
> From: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
>
> This patch contains the routines to save, retrieve and remove the vmids
> from the data structure. A hash table is used to save the vmids and
> the corresponding UUIDs associated with the application/VMs.
>
> Signed-off-by: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
>
> ---
> v8:
> Added correct return value and error codes
>
> v7:
> No change
>
> v6:
> Added Forward declarations and functions to static
>
> v5:
> Changed Return code to non-numeric/Symbol
>
> v4:
> No change
>
> v3:
> No change
>
> v2:
> Ported the patch on top of 5.10/scsi-queue
> ---
> drivers/scsi/lpfc/lpfc_scsi.c | 148 ++++++++++++++++++++++++++++++++++
> 1 file changed, 148 insertions(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index e96e767faa2a..b71602878559 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -28,6 +28,7 @@
> #include <asm/unaligned.h>
> #include <linux/t10-pi.h>
> #include <linux/crc-t10dif.h>
> +#include <linux/blk-cgroup.h>
> #include <net/checksum.h>
>
> #include <scsi/scsi.h>
> @@ -86,6 +87,14 @@ static void
> lpfc_release_scsi_buf_s3(struct lpfc_hba *phba, struct lpfc_io_buf *psb);
> static int
> lpfc_prot_group_type(struct lpfc_hba *phba, struct scsi_cmnd *sc);
> +static int
> +lpfc_put_vmid_in_hashtable(struct lpfc_vport *vport, u32 hash,
> + struct lpfc_vmid *vmp);
> +static void lpfc_vmid_update_entry(struct lpfc_vport *vport, struct scsi_cmnd
> + *cmd, struct lpfc_vmid *vmp,
> + union lpfc_vmid_io_tag *tag);
> +static void lpfc_vmid_assign_cs_ctl(struct lpfc_vport *vport,
> + struct lpfc_vmid *vmid);
>
> static inline unsigned
> lpfc_cmd_blksize(struct scsi_cmnd *sc)
> @@ -5131,6 +5140,145 @@ void lpfc_poll_timeout(struct timer_list *t)
> }
> }
>
> +/*
> + * lpfc_get_vmid_from_hastable - search the UUID in the hash table
Should be 'lpfc_get_vmid_from_hashtable()'.
> + * @vport: The virtual port for which this call is being executed.
> + * @hash: calculated hash value
> + * @buf: uuid associated with the VE
> + * Returns the vmid entry associated with the UUID
> + * Make sure to acquire the appropriate lock before invoking this routine.
> + */
> +struct lpfc_vmid *lpfc_get_vmid_from_hastable(struct lpfc_vport *vport,
> + u32 hash, u8 *buf)
> +{
> + struct lpfc_vmid *vmp;
> + u16 count = 0;
> +
> + while (count < LPFC_VMID_HASH_SIZE) {
> + vmp = vport->hash_table[hash];
> + if (vmp) {
> + if (strncmp(&vmp->host_vmid[0], buf, 16) == 0)
> + return vmp;
> + } else {
> + return NULL;
> + }
> + /* search the next available slot and continue till entry */
> + /* is found */
> + count++;
> + hash++;
> +
> + /* or the end is reached */
> + if (hash == LPFC_VMID_HASH_SIZE)
> + hash = 0;
> + }
> + return NULL;
> +}
> +
> +/*
> + * lpfc_put_vmid_from_hastable - put the VMID in the hash table
> + * @vport: The virtual port for which this call is being executed.
> + * @hash - calculated hash value
> + * @vmp: Pointer to a VMID entry representing a VM sending IO
> + *
> + * This routine will insert the newly acquired vmid entity in the hash table.
> + * Make sure to acquire the appropriate lock before invoking this routine.
> + */
> +static int
> +lpfc_put_vmid_in_hashtable(struct lpfc_vport *vport, u32 hash,
> + struct lpfc_vmid *vmp)
> +{
> + int count = 0;
> +
> + while (count < LPFC_VMID_HASH_SIZE) {
> + if (!vport->hash_table[hash]) {
> + vport->hash_table[hash] = vmp;
> + vmp->hash_index = hash;
> + return 0;
> + }
> + /* if the slot is already occupied, a collision has occurred. */
> + /* Store in the next available slot */
> + count++;
> + hash++;
> + /* table is full */
> + if (hash == LPFC_VMID_HASH_SIZE)
> + hash = 0;
> + }
> + return -ENOMEM;
> +}
> +
> +/*
> + * lpfc_vmid_hash_fn - creates a hash value of the UUID
> + * @vmid: uuid associated with the VE
> + * @len: length of the vmid string
> + * Returns the calculated hash value
> + */
> +int lpfc_vmid_hash_fn(const char *vmid, int len)
> +{
> + int c;
> + int hash = 0;
> +
> + if (len == 0)
> + return 0;
> + while (len--) {
> + c = *vmid++;
> + if (c >= 'A' && c <= 'Z')
> + c += 'a' - 'A';
> +
> + hash = (hash + (c << LPFC_VMID_HASH_SHIFT) +
> + (c >> LPFC_VMID_HASH_SHIFT)) * 19;
> + }
> +
> + return hash & LPFC_VMID_HASH_MASK;
> +}
> +
Any particular reason why you didn't use a generic hashtable
implementation here?
(cf include/linux/hashtable.h)
> +/*
> + * lpfc_vmid_update_entry - update the vmid entry in the hash table
> + * @vport: The virtual port for which this call is being executed.
> + * @cmd: address of scsi cmmd descriptor
> + * @vmp: Pointer to a VMID entry representing a VM sending IO
> + * @tag: VMID tag
> + */
> +static void lpfc_vmid_update_entry(struct lpfc_vport *vport, struct scsi_cmnd
> + *cmd, struct lpfc_vmid *vmp,
> + union lpfc_vmid_io_tag *tag)
> +{
> + u64 *lta;
> +
> + if (vport->vmid_priority_tagging)
> + tag->cs_ctl_vmid = vmp->un.cs_ctl_vmid;
> + else
> + tag->app_id = vmp->un.app_id;
> +
> + if (cmd->sc_data_direction == DMA_TO_DEVICE)
> + vmp->io_wr_cnt++;
> + else
> + vmp->io_rd_cnt++;
> +
> + /* update the last access timestamp in the table */
> + lta = per_cpu_ptr(vmp->last_io_time, raw_smp_processor_id());
> + *lta = jiffies;
> +}
> +
> +static void lpfc_vmid_assign_cs_ctl(struct lpfc_vport *vport,
> + struct lpfc_vmid *vmid)
> +{
> + u32 hash;
> + struct lpfc_vmid *pvmid;
> +
> + if (vport->port_type == LPFC_PHYSICAL_PORT) {
> + vmid->un.cs_ctl_vmid = lpfc_vmid_get_cs_ctl(vport);
> + } else {
> + hash = lpfc_vmid_hash_fn(vmid->host_vmid, vmid->vmid_len);
> + pvmid =
> + lpfc_get_vmid_from_hastable(vport->phba->pport, hash,
> + vmid->host_vmid);
> + if (pvmid)
> + vmid->un.cs_ctl_vmid = pvmid->un.cs_ctl_vmid;
> + else
> + vmid->un.cs_ctl_vmid = lpfc_vmid_get_cs_ctl(vport);
> + }
> +}
> +
> /**
> * lpfc_queuecommand - scsi_host_template queuecommand entry point
> * @shost: kernel scsi host pointer.
>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-04 12:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 5:27 [PATCH v8 00/16] blkcg:Support to track FC storage blk io traffic Muneendra
2021-03-04 5:27 ` [PATCH v8 01/16] cgroup: Added cgroup_get_from_id Muneendra
2021-03-04 12:25 ` Hannes Reinecke
2021-03-04 16:26 ` kernel test robot
2021-03-04 5:27 ` [PATCH v8 02/16] blkcg: Added a app identifier support for blkcg Muneendra
2021-03-04 12:25 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 03/16] nvme: Added a newsysfs attribute appid_store Muneendra
2021-03-04 12:27 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 04/16] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2021-03-04 12:29 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 05/16] lpfc: vmid: Supplementary data structures for vmid and APIs Muneendra
2021-03-04 12:31 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 06/16] lpfc: vmid: Forward declarations for APIs Muneendra
2021-03-04 12:32 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 07/16] lpfc: vmid: VMID params initialization Muneendra
2021-03-04 12:33 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 08/16] lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup Muneendra
2021-03-04 12:34 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 09/16] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2021-03-04 12:36 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 10/16] lpfc: vmid: Functions to manage vmids Muneendra
2021-03-04 12:41 ` Hannes Reinecke [this message]
2021-03-04 5:27 ` [PATCH v8 11/16] lpfc: vmid: Implements CT commands for appid Muneendra
2021-03-04 12:42 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 12/16] lpfc: vmid: Appends the vmid in the wqe before sending Muneendra
2021-03-04 12:43 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 13/16] lpfc: vmid: Timeout implementation for vmid Muneendra
2021-03-04 12:46 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 14/16] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2021-03-04 12:47 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 15/16] lpfc: vmid: Introducing vmid in io path Muneendra
2021-03-04 12:52 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 16/16] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2021-03-04 12:53 ` Hannes Reinecke
2021-03-11 15:33 ` [PATCH v8 00/16] blkcg:Support to track FC storage blk io traffic Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57930010-ab0a-0d95-210b-3b578fd649ff@suse.de \
--to=hare@suse.de \
--cc=emilne@redhat.com \
--cc=gaurav.srivastava@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).