From: <tsutomu.owa@kioxia.com>
To: <kbusch@kernel.org>
Cc: hch@infradead.org, tsutomu.owa@kioxia.com, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: RE: [RFC PATCH 0/5] to add more nvme reset functions
Date: Thu, 12 Dec 2019 08:36:27 +0000 [thread overview]
Message-ID: <58ecb196bb1844fda85b3ae4bfc5bfe4@tgxml778.toshiba.local> (raw)
In-Reply-To: <20191211161823.GA493@redsun51.ssa.fujisawa.hgst.com>
Hi Keith-san,
Thank you for your reply.
> From: Keith Busch [mailto:kbusch@kernel.org]
> Sent: Thursday, December 12, 2019 1:18 AM
> You're not providing any justification for why you want these implemented
> in the nvme driver. What issue is this addressing?
Please give me some time to write it in another email.
> First, if you're going to introduce a Kconfig option, don't split the
> patch that actually uses it. Second, don't introduce new kernel config
> options for such features in the first place.
Ok, I'll remove these Kconfig option.
> > - what is the best way to export nvme_pci_* functions in
> > drivers/nvme/host/pci.c to drivers/nvme/host/core.c.
>
> Don't export functions that direction. Use ctrl->ops if core needs to
> call a transport specific routine.
Yes, I'll use ctrl-ops if needed.
> > I'm still wondoring
> > - if it's ok to export functions from drivers/pci.
>
> Probably not. They are private for a reason.
> > Any comments would be highly appreciated.
>
> The majority of this series is at the pci protocol level, and the pci
> driver already provides the requested capabilities (but with a more
> safe implementation). Let's not reinvent it just because one nvme
> transport happens to use the pci bus.
Thank you for the comment. I'll look into the pci driver again to look for
functions avilable. Would you please point out function names good for
conventional hot reset and/or link down reset which can be called within
the kernel if you know.
thanks for your time.
-- owa
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-12 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 2:34 [RFC PATCH 0/5] to add more nvme reset functions tsutomu.owa
2019-12-11 16:18 ` Keith Busch
2019-12-12 0:50 ` Sagi Grimberg
2019-12-12 8:30 ` Christoph Hellwig
2019-12-12 8:41 ` tsutomu.owa
2019-12-12 8:36 ` tsutomu.owa [this message]
2019-12-12 18:36 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ecb196bb1844fda85b3ae4bfc5bfe4@tgxml778.toshiba.local \
--to=tsutomu.owa@kioxia.com \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).