From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 871E4C4740A for ; Mon, 7 Oct 2019 07:45:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A662133F for ; Mon, 7 Oct 2019 07:45:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pb8NaHzX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=yadro.com header.i=@yadro.com header.b="geZ53Rj2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51A662133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yadro.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZvHJy+XT9ckfBnjgJ9PMyeTEb5TRpb01cMKvr13DwxQ=; b=Pb8NaHzX3IpZRP qr7hYaaA/uLlzUcyeeCg9xsH3dX6lwulS9/9dSuihsD59biD3Pd6XOgZGYDnkPEIIUDVspSZbpi/L 7RrJU30e4AFowl5wM4NbPkOrx+nfI3FfCVTAjg4bBLw9kGLJRD5Xw4+dV7fGXupbnPrIS3B5ssttV 2VF3iHPnJqBuhdRFjesWIsbgkjXSL5GsPvC65lQM29Z32Tol+vz7cr3xdNPpSgJbrnPUqh84ODdFH DlFqs4F8bRvocYVLn5OFhJrJJXRXCWI+dd7tmkvByUjfnFJlRJIHdQoNJPXvIJqWQ1QSq4ka6jNhm W7VQAPGUso7AOStD+RAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHNho-0008Vf-D4; Mon, 07 Oct 2019 07:45:20 +0000 Received: from mta-02.yadro.com ([89.207.88.252] helo=mta-01.yadro.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHNhl-0008I5-1i for linux-nvme@lists.infradead.org; Mon, 07 Oct 2019 07:45:18 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 36ED341207; Mon, 7 Oct 2019 07:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= mime-version:content-transfer-encoding:content-id:content-type :content-type:content-language:accept-language:in-reply-to :references:message-id:date:date:subject:subject:from:from :received:received:received:received; s=mta-01; t=1570434314; x= 1572248715; bh=jLN83xO37OInKn0O0TuZ8M9JH4HGvt1kzqGuzaILytQ=; b=g eZ53Rj2EC+m2GoRERDOKrph4Gb3Lq12X6JAw2MarexXwao6a8DvU20GLkuX+C7rq V9gSAon3uNTU93ArLbAtnxbinOeGSyWsAksR1l8djyHpANDGB0/gI+Hy4CcVW4cM akDf4itGLhyp6DXWYMuA7QeJWAPe1xlHiLu5SREjXg= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eclh4WAx8WC2; Mon, 7 Oct 2019 10:45:14 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 07F8441203; Mon, 7 Oct 2019 10:45:14 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (172.17.10.102) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Mon, 7 Oct 2019 10:45:13 +0300 Received: from T-EXCH-02.corp.yadro.com ([fe80::19dd:9b61:5447:ff23]) by T-EXCH-02.corp.yadro.com ([fe80::19dd:9b61:5447:ff23%14]) with mapi id 15.01.0669.032; Mon, 7 Oct 2019 10:45:13 +0300 From: Mikhail Malygin To: Christoph Hellwig Subject: Re: [PATCH v2] nvmet: add revalidate ns sysfs attribute to handle device resize Thread-Topic: [PATCH v2] nvmet: add revalidate ns sysfs attribute to handle device resize Thread-Index: AQHVd6AJCekf5mvAfEK6Mx5ufLPLaqdK/yAAgAI8YICAAWlDgA== Date: Mon, 7 Oct 2019 07:45:13 +0000 Message-ID: <5DA98541-6318-4BB5-9CA5-CE0E013FBA0C@yadro.com> References: <20190926231940.7494-1-m.malygin@yadro.com> <20190930150202.9259-1-m.malygin@yadro.com> <11e37d39-c85e-f844-953f-f540596b4410@grimberg.me> <20191006101213.GA30175@infradead.org> In-Reply-To: <20191006101213.GA30175@infradead.org> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [10.100.1.26] Content-ID: <769A43189D6881448DE76EFEE52160BD@yadro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_004517_369462_0DA866F3 X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , "linux-nvme@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Just posted updated version with code style cleanup. > On 6 Oct 2019, at 13:12, Christoph Hellwig wrote: > > On Fri, Oct 04, 2019 at 05:03:36PM -0700, Sagi Grimberg wrote: >> This looks fine to me, >> >> Christoph, you happy with this version? >> > > Conceptually yes, but it really needs to at least follow the kernel > style. I'm also not sure I'm happy about all the extra indirections, > but I can be talked into it. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme