From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 1/6] nvme-auth: rename __nvme_auth_[reset|free] to nvme_auth[reset|free]_dhchap
Date: Tue, 25 Oct 2022 17:34:42 +0000 [thread overview]
Message-ID: <640c0852-0904-f968-995d-7f2640c3f1bd@nvidia.com> (raw)
In-Reply-To: <20221025134330.1028352-2-sagi@grimberg.me>
On 10/25/2022 6:43 AM, Sagi Grimberg wrote:
> nvme_auth_[reset|free] operate on the controller while
> __nvme_auth_[reset|free] operate on a chap struct (which maps to a queue
> context). Rename it for clarity.
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-10-25 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 13:43 [PATCH 0/6] nvme: a few nvme-auth fixes found during code browsing Sagi Grimberg
2022-10-25 13:43 ` [PATCH 1/6] nvme-auth: rename __nvme_auth_[reset|free] to nvme_auth[reset|free]_dhchap Sagi Grimberg
2022-10-25 17:18 ` Hannes Reinecke
2022-10-25 17:34 ` Chaitanya Kulkarni [this message]
2022-10-25 13:43 ` [PATCH 2/6] nvme-auth: remove symbol export from nvme_auth_reset Sagi Grimberg
2022-10-25 17:18 ` Hannes Reinecke
2022-10-25 17:34 ` Chaitanya Kulkarni
2022-10-25 13:43 ` [PATCH 3/6] nvme-auth: don't re-authenticate if the controller is not LIVE Sagi Grimberg
2022-10-25 17:22 ` Hannes Reinecke
2022-10-25 20:22 ` Sagi Grimberg
2022-10-25 13:43 ` [PATCH 4/6] nvme-auth: remove redundant buffer deallocations Sagi Grimberg
2022-10-25 17:23 ` Hannes Reinecke
2022-10-25 17:36 ` Chaitanya Kulkarni
2022-10-25 13:43 ` [PATCH 5/6] nvme-auth: don't ignore key generation failures when initializing ctrl keys Sagi Grimberg
2022-10-25 17:24 ` Hannes Reinecke
2022-10-25 13:43 ` [PATCH 6/6] nvme-auth: don't override ctrl keys before validation Sagi Grimberg
2022-10-25 17:25 ` Hannes Reinecke
2022-10-25 15:32 ` [PATCH 0/6] nvme: a few nvme-auth fixes found during code browsing Christoph Hellwig
2022-10-25 15:46 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=640c0852-0904-f968-995d-7f2640c3f1bd@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).