From: Sagi Grimberg <sagi@grimberg.me>
To: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Cc: Edmund Nadolski <edmund.nadolski@intel.com>
Subject: Re: [PATCH 1/5] nvme: Restart request timers in resetting state
Date: Thu, 5 Sep 2019 13:13:43 -0700 [thread overview]
Message-ID: <65aa0709-c8a7-2988-864a-4bda0a4c3ce8@grimberg.me> (raw)
In-Reply-To: <20190905142607.24897-1-kbusch@kernel.org>
> + /*
> + * Restart the timer if a controller reset is already scheduled. Any
> + * timed out commands would be handled before entering the connecting
> + * state.
> + */
> + if (ctrl->ctrl.state == NVME_CTRL_RESETTING)
> + return BLK_EH_RESET_TIMER;
> +
> if (ctrl->ctrl.state != NVME_CTRL_LIVE) {
Not sure I understand what exactly is this solving? if the controller is
not responding to a connect command, we just added another ADMIN_TIMEOUT
to failing it.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-05 20:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 14:26 [PATCH 1/5] nvme: Restart request timers in resetting state Keith Busch
2019-09-05 14:26 ` [PATCH 2/5] nvme: Prevent resets during paused states Keith Busch
2019-09-05 20:23 ` Sagi Grimberg
2019-09-05 20:35 ` Keith Busch
2019-09-05 20:42 ` Sagi Grimberg
2019-09-05 14:26 ` [PATCH 3/5] nvme-pci: Free tagset if no IO queues Keith Busch
2019-09-05 20:24 ` Sagi Grimberg
2019-09-05 20:40 ` Keith Busch
2019-09-05 20:43 ` Sagi Grimberg
2019-09-05 14:26 ` [PATCH 4/5] nvme: Remove ADMIN_ONLY state Keith Busch
2019-09-05 14:26 ` [PATCH 5/5] nvme: Wait for reset state when required Keith Busch
2019-09-05 15:57 ` James Smart
2019-09-05 20:47 ` Sagi Grimberg
2019-09-05 20:55 ` Keith Busch
2019-09-05 20:13 ` Sagi Grimberg [this message]
2019-09-05 20:25 ` [PATCH 1/5] nvme: Restart request timers in resetting state Keith Busch
2019-09-05 20:39 ` Sagi Grimberg
2019-09-05 21:36 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65aa0709-c8a7-2988-864a-4bda0a4c3ce8@grimberg.me \
--to=sagi@grimberg.me \
--cc=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).