From: Bart Van Assche <bvanassche@acm.org>
To: Jason Gunthorpe <jgg@mellanox.com>, Max Gurtovoy <maxg@mellanox.com>
Cc: loberman@redhat.com, sagi@grimberg.me, vladimirk@mellanox.com,
idanb@mellanox.com, linux-rdma@vger.kernel.org,
shlomin@mellanox.com, linux-nvme@lists.infradead.org,
leonro@mellanox.com, dledford@redhat.com, oren@mellanox.com,
kbusch@kernel.org, rgirase@redhat.com, hch@lst.de
Subject: Re: [PATCH v2 3/5] nvmet-rdma: use SRQ per completion vector
Date: Thu, 19 Mar 2020 07:49:31 -0700 [thread overview]
Message-ID: <6dcf300c-d010-829b-b996-285ad16786d5@acm.org> (raw)
In-Reply-To: <20200319135356.GZ13183@mellanox.com>
On 3/19/20 6:53 AM, Jason Gunthorpe wrote:
> On Thu, Mar 19, 2020 at 02:48:20PM +0200, Max Gurtovoy wrote:
>
>> Nevertheless, this situation is better from the current SRQ per HCA
>> implementation.
>
> nvme/srp/etc already use srq? I see it in the target but not initiator?
>
> Just worried about breaking some weird target somewhere
From the upstream SRP target driver:
static void srpt_get_ioc(struct srpt_port *sport, u32 slot,
struct ib_dm_mad *mad)
{
[ ... ]
if (sdev->use_srq)
send_queue_depth = sdev->srq_size;
else
send_queue_depth = min(MAX_SRPT_RQ_SIZE,
sdev->device->attrs.max_qp_wr);
[ ... ]
iocp->send_queue_depth = cpu_to_be16(send_queue_depth);
[ ... ]
}
I'm not sure the SRP initiator uses that data from the device management
I/O controller profile.
Anyway, with one SRQ per initiator it is possible for the initiator to
prevent SRQ overflows. I don't think that it is possible for an initiator
to prevent target side SRQ overflows if shared receive queues are shared
across multiple initiators.
Thanks,
Bart.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-19 14:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:02 [PATCH v2 0/5] nvmet-rdma/srpt: SRQ per completion vector Max Gurtovoy
2020-03-18 15:02 ` [PATCH v2 1/5] IB/core: add a simple SRQ pool per PD Max Gurtovoy
2020-03-20 5:59 ` Sagi Grimberg
2020-03-20 13:21 ` Max Gurtovoy
2020-03-20 14:27 ` Leon Romanovsky
2020-03-18 15:02 ` [PATCH v2 2/5] nvmet-rdma: add srq pointer to rdma_cmd Max Gurtovoy
2020-03-18 23:32 ` Jason Gunthorpe
2020-03-19 8:48 ` Max Gurtovoy
2020-03-19 9:14 ` Leon Romanovsky
2020-03-19 10:55 ` Max Gurtovoy
2020-03-19 11:54 ` Jason Gunthorpe
2020-03-19 14:08 ` Konstantin Ryabitsev
2020-03-19 21:58 ` Konstantin Ryabitsev
2020-03-19 4:05 ` Bart Van Assche
2020-03-18 15:02 ` [PATCH v2 3/5] nvmet-rdma: use SRQ per completion vector Max Gurtovoy
2020-03-19 4:09 ` Bart Van Assche
2020-03-19 9:15 ` Max Gurtovoy
2020-03-19 11:56 ` Jason Gunthorpe
2020-03-19 12:48 ` Max Gurtovoy
2020-03-19 13:53 ` Jason Gunthorpe
2020-03-19 14:49 ` Bart Van Assche [this message]
[not found] ` <50dd8f5d-d092-54bc-236d-1e702fb95240@mellanox.com>
[not found] ` <6e3cc1c4-b24e-f607-42b3-5b83dd8c312c@mellanox.com>
2020-03-19 16:27 ` Max Gurtovoy
2020-03-20 5:47 ` Sagi Grimberg
2020-03-18 15:02 ` [PATCH v2 4/5] RDMA/srpt: use ib_alloc_cq instead of ib_alloc_cq_any Max Gurtovoy
2020-03-19 4:15 ` Bart Van Assche
2020-03-18 15:02 ` [PATCH v2 5/5] RDMA/srpt: use SRQ per completion vector Max Gurtovoy
2020-03-19 4:20 ` Bart Van Assche
2020-03-19 4:02 ` [PATCH v2 0/5] nvmet-rdma/srpt: " Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dcf300c-d010-829b-b996-285ad16786d5@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=idanb@mellanox.com \
--cc=jgg@mellanox.com \
--cc=kbusch@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=maxg@mellanox.com \
--cc=oren@mellanox.com \
--cc=rgirase@redhat.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).