Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* NVMeoF driver & Reservations
       [not found] <92087051575042507@sas2-7fadb031fd9b.qloud-c.yandex.net>
@ 2019-11-29 15:50 ` Talker Alex
  2019-12-02 22:07   ` Chaitanya Kulkarni
  0 siblings, 1 reply; 5+ messages in thread
From: Talker Alex @ 2019-11-29 15:50 UTC (permalink / raw)
  To: linux-nvme

Hi!

Is there plans to implement Reservations support in target driver(from NVMe v1.4 part 8.8)?
I see that host support is already implemented in nvme utility & driver level.
However, I haven't found hardware on which it works - target driver doesn't support this command and PCIe drives available to me also.

So, I'm wondering if anyone begin to implement this feature at least on single target level.

------------------
Best regards,
Alex
>

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: NVMeoF driver & Reservations
  2019-11-29 15:50 ` NVMeoF driver & Reservations Talker Alex
@ 2019-12-02 22:07   ` Chaitanya Kulkarni
  2019-12-03  8:51     ` Talker Alex
  2019-12-03 16:08     ` Bart Van Assche
  0 siblings, 2 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2019-12-02 22:07 UTC (permalink / raw)
  To: Talker Alex, linux-nvme

On 12/01/2019 02:19 AM, Talker Alex wrote:
> Hi!
>
> Is there plans to implement Reservations support in target driver(from NVMe v1.4 part 8.8)?
> I see that host support is already implemented in nvme utility & driver level.
> However, I haven't found hardware on which it works - target driver doesn't support this command and PCIe drives available to me also.
>
> So, I'm wondering if anyone begin to implement this feature at least on single target level.

Yes there is and I also have testcases to test this feature from host side.

for target I did start working on this but stopped it since I didn't
find proper use-case (or a client) for it to justify the effort and
code getting into kernel. But if you have a legit scenario or a
use-case I'll be happy to work on this.


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: NVMeoF driver & Reservations
  2019-12-02 22:07   ` Chaitanya Kulkarni
@ 2019-12-03  8:51     ` Talker Alex
  2019-12-03 16:08     ` Bart Van Assche
  1 sibling, 0 replies; 5+ messages in thread
From: Talker Alex @ 2019-12-03  8:51 UTC (permalink / raw)
  To: linux-nvme

> But if you have a legit scenario or a
> use-case I'll be happy to work on this.

I think in SCSI subsystems this support is usually made to pass-by Microsoft Windows Server Failover Clustering requirements.
Regarding the use-case I think this is as usual an effort to create
a lock mechanism in order to synchronize access to the same device without an additional layer on client side.

I don't know whether NVMeoF works on Windows at all by now, haven't checked yet.
Anyway, I'd like to see your code if you published it anywhere.
Unlikely with SCSI, NVMe Reservations seems to be easier to implement with dedicated HostNQN identifier,
digging through the specification conditions.

------------------
Best regards,
Alex

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: NVMeoF driver & Reservations
  2019-12-02 22:07   ` Chaitanya Kulkarni
  2019-12-03  8:51     ` Talker Alex
@ 2019-12-03 16:08     ` Bart Van Assche
  2019-12-03 19:54       ` Chaitanya Kulkarni
  1 sibling, 1 reply; 5+ messages in thread
From: Bart Van Assche @ 2019-12-03 16:08 UTC (permalink / raw)
  To: Chaitanya Kulkarni, Talker Alex, linux-nvme

On 12/2/19 2:07 PM, Chaitanya Kulkarni wrote:
> On 12/01/2019 02:19 AM, Talker Alex wrote:
>> Hi!
>>
>> Is there plans to implement Reservations support in target driver(from NVMe v1.4 part 8.8)?
>> I see that host support is already implemented in nvme utility & driver level.
>> However, I haven't found hardware on which it works - target driver doesn't support this command and PCIe drives available to me also.
>>
>> So, I'm wondering if anyone begin to implement this feature at least on single target level.
> 
> Yes there is and I also have testcases to test this feature from host side.
> 
> for target I did start working on this but stopped it since I didn't
> find proper use-case (or a client) for it to justify the effort and
> code getting into kernel. But if you have a legit scenario or a
> use-case I'll be happy to work on this.

Hi Chaitanya,

If you would be considering to develop test code for NVMe reservations, 
you may want to have a look at the SCSI persistent reservation tests in 
the libiscsi test-tool 
(https://github.com/sahlberg/libiscsi/tree/master/test-tool).

Bart.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: NVMeoF driver & Reservations
  2019-12-03 16:08     ` Bart Van Assche
@ 2019-12-03 19:54       ` Chaitanya Kulkarni
  0 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2019-12-03 19:54 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: Talker Alex, linux-nvme

Indeed I have looked into this and it's very helpful. 
Thanks for reminding me again :). 
> On Dec 3, 2019, at 8:08 AM, Bart Van Assche <bvanassche@acm.org> wrote:
> 
> On 12/2/19 2:07 PM, Chaitanya Kulkarni wrote:
>>> On 12/01/2019 02:19 AM, Talker Alex wrote:
>>> Hi!
>>> 
>>> Is there plans to implement Reservations support in target driver(from NVMe v1.4 part 8.8)?
>>> I see that host support is already implemented in nvme utility & driver level.
>>> However, I haven't found hardware on which it works - target driver doesn't support this command and PCIe drives available to me also.
>>> 
>>> So, I'm wondering if anyone begin to implement this feature at least on single target level.
>> Yes there is and I also have testcases to test this feature from host side.
>> for target I did start working on this but stopped it since I didn't
>> find proper use-case (or a client) for it to justify the effort and
>> code getting into kernel. But if you have a legit scenario or a
>> use-case I'll be happy to work on this.
> 
> Hi Chaitanya,
> 
> If you would be considering to develop test code for NVMe reservations, you may want to have a look at the SCSI persistent reservation tests in the libiscsi test-tool (https://github.com/sahlberg/libiscsi/tree/master/test-tool).
> 
> Bart.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <92087051575042507@sas2-7fadb031fd9b.qloud-c.yandex.net>
2019-11-29 15:50 ` NVMeoF driver & Reservations Talker Alex
2019-12-02 22:07   ` Chaitanya Kulkarni
2019-12-03  8:51     ` Talker Alex
2019-12-03 16:08     ` Bart Van Assche
2019-12-03 19:54       ` Chaitanya Kulkarni

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git