From: Logan Gunthorpe <logang@deltatee.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH blktests] nvme/031: Add test to check controller deletion after setup
Date: Mon, 9 Sep 2019 10:13:56 -0600 [thread overview]
Message-ID: <7ae33b82-88d7-2fa3-2bc3-da0b262d0ee8@deltatee.com> (raw)
In-Reply-To: <BYAPR04MB5749A3E9B06514AF589FE13B86B50@BYAPR04MB5749.namprd04.prod.outlook.com>
On 2019-09-07 12:19 p.m., Chaitanya Kulkarni wrote:
> On 09/05/2019 10:44 AM, Logan Gunthorpe wrote:
>> A number of bug fixes have been submitted to the kernel to
>> fix bugs when a controller is removed immediately after it is
>> set up. This new test ensures this doesn't regress.
>>
>> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
>>
>> ---
>>
>> This is reallly just a resend. The patches this tests for are all in
>> 5.3-rc7 or earlier and it passes on said kernel version.
>>
>> I've rebased this patch onto the latest blktests as of today with no
>> changes required.
>>
>> Thanks,
>>
>> Logan
>>
>> tests/nvme/031 | 55 ++++++++++++++++++++++++++++++++++++++++++++++
>> tests/nvme/031.out | 2 ++
>> 2 files changed, 57 insertions(+)
>> create mode 100755 tests/nvme/031
>> create mode 100644 tests/nvme/031.out
>>
>> diff --git a/tests/nvme/031 b/tests/nvme/031
>> new file mode 100755
>> index 000000000000..16390dcb380e
>> --- /dev/null
>> +++ b/tests/nvme/031
>> @@ -0,0 +1,55 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-3.0+
>> +# Copyright (C) 2019 Logan Gunthorpe
>> +#
>> +# Regression test for the following patches:
>> +# nvme: fix controller removal race with scan work
>> +# nvme: fix regression upon hot device removal and insertion
>> +# nvme-core: Fix extra device_put() call on error path
>> +# nvmet-loop: Flush nvme_delete_wq when removing the port
>> +# nvmet: Fix use-after-free bug when a port is removed
>> +#
>> +# All these patches fix issues related to deleting a controller
>> +# immediately after setting it up.
>> +
>> +. tests/nvme/rc
>> +
>> +DESCRIPTION="test deletion of NVMeOF controllers immediately after setup"
>> +QUICK=1
>> +
>> +requires() {
>> + _have_program nvme &&
>> + _have_modules loop nvme-loop nvmet &&
>> + _have_configfs
>> +}
>> +
>> +test() {
>> + local subsys="blktests-subsystem-"
>> + local iterations=10
>> + local loop_dev
>> + local port
>> +
>> + echo "Running ${TEST_NAME}"
>> +
>> + _setup_nvmet
>> +
>> + truncate -s 1G "$TMPDIR/img"
>> +
>> + local loop_dev
> Duplicate declaration of the local variable ?
Oops, yes, nice catch. I'll send an updated patch later this week.
Logan
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-09 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 17:43 [PATCH blktests] nvme/031: Add test to check controller deletion after setup Logan Gunthorpe
2019-09-05 20:54 ` Sagi Grimberg
2019-09-07 18:19 ` Chaitanya Kulkarni
2019-09-09 16:13 ` Logan Gunthorpe [this message]
2019-09-09 17:06 ` Chaitanya Kulkarni
-- strict thread matches above, loose matches on Subject: below --
2019-07-31 23:47 Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae33b82-88d7-2fa3-2bc3-da0b262d0ee8@deltatee.com \
--to=logang@deltatee.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).