From: Eduard Hasenleithner <eduard@hasenleithner.at>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [RFC PATCH v2] Workaround for discard on non-conformant nvme devices
Date: Mon, 11 Nov 2019 23:10:11 +0100 [thread overview]
Message-ID: <7f3256e5-6f7f-16ad-65b9-6d7701c88dba@hasenleithner.at> (raw)
In-Reply-To: <20191111185830.GD10851@redsun51.ssa.fujisawa.hgst.com>
On 11.11.19 19:58, Keith Busch wrote:
> Please initialize 'range' to NULL so we don't need the 'else' case.
...
> Let's get a better description of this. My recommendation:
>
> For devices that do not consider the DSM 'Number of Ranges'
> field when determining how much data to DMA. Page aligned and
> sized is always sufficient as that is the largest a DSM range
> list can be.
>
> And let's add the known devices to the nvme pci_driver that require
> this.
Thanks for the input. I've considered this in the next version: PATCHv3.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-11-11 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 18:27 [RFC PATCH v2] Workaround for discard on non-conformant nvme devices Eduard Hasenleithner
2019-11-11 10:28 ` Christoph Hellwig
2019-11-11 18:58 ` Keith Busch
2019-11-11 22:10 ` Eduard Hasenleithner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f3256e5-6f7f-16ad-65b9-6d7701c88dba@hasenleithner.at \
--to=eduard@hasenleithner.at \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).