From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <maxg@mellanox.com>,
linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de
Cc: shlomin@mellanox.com, jgg@mellanox.com, bvanassche@acm.org
Subject: Re: [PATCH v4 1/1] nvmet-rdma: use SRQ per completion vector
Date: Thu, 26 Mar 2020 16:20:50 -0700 [thread overview]
Message-ID: <80ff5951-caad-1130-43d4-6239b9f6a143@grimberg.me> (raw)
In-Reply-To: <20200326181512.58053-1-maxg@mellanox.com>
> @@ -954,7 +1039,7 @@ static void nvmet_rdma_free_dev(struct kref *ref)
> goto out_free_dev;
>
> if (nvmet_rdma_use_srq) {
> - ret = nvmet_rdma_init_srq(ndev);
> + ret = nvmet_rdma_init_srqs(ndev);
> if (ret)
> goto out_free_pd;
> }
I'm wandering if we should fallback to normal rqs, probably not a
good idea...
> @@ -1238,6 +1326,10 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
> case IB_EVENT_COMM_EST:
> rdma_notify(queue->cm_id, event->event);
> break;
> + case IB_EVENT_QP_LAST_WQE_REACHED:
> + pr_debug("received last WQE reached event for queue=0x%p\n",
> + queue);
> + break;
Can you remind me when does this event come up? Why don't we see it with
normal queues?
Other than that, looks good Max,
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-03-26 23:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 18:15 [PATCH v4 1/1] nvmet-rdma: use SRQ per completion vector Max Gurtovoy
2020-03-26 18:29 ` Laurence Oberman
2020-03-26 22:14 ` Max Gurtovoy
2020-03-26 23:20 ` Sagi Grimberg [this message]
2020-03-27 0:44 ` Max Gurtovoy
2020-03-31 14:43 ` Max Gurtovoy
2020-03-31 15:06 ` Christoph Hellwig
2020-04-01 8:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ff5951-caad-1130-43d4-6239b9f6a143@grimberg.me \
--to=sagi@grimberg.me \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).