Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
@ 2019-09-11 21:21 Gabriel C
  2019-09-11 21:33 ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel C @ 2019-09-11 21:21 UTC (permalink / raw)
  To: LKML, linux-nvme; +Cc: Sagi Grimberg

 Booting with default_ps_max_latency_us >6000 makes the device fail.
 Also SUBNQN is NULL and gives a warning on each boot/resume.
  $ nvme id-ctrl /dev/nvme0 | grep ^subnqn
    subnqn    : (null)

 I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
 To be sure is not a Laptop issue only, I tested the device on
 my server board too with the same results.
 ( with 2x,4x link on the board and 4x on a PCI-E card ).

 Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
 Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
---
 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 52205f8d90b4..3093f224c7ac 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3079,6 +3079,9 @@ static const struct pci_device_id nvme_id_table[] = {
                .driver_data = NVME_QUIRK_LIGHTNVM, },
        { PCI_DEVICE(0x10ec, 0x5762),   /* ADATA SX6000LNP */
                .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+        { PCI_DEVICE(0x1cc1, 0x8201),   /* ADATA SX8200PNP 512GB */
+                .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
+                                NVME_QUIRK_IGNORE_DEV_SUBNQN, },
        { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
        { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
        { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
-- 
2.21.0

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
  2019-09-11 21:21 [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB Gabriel C
@ 2019-09-11 21:33 ` Jens Axboe
  2019-09-11 22:18   ` Gabriel C
  0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2019-09-11 21:33 UTC (permalink / raw)
  To: Gabriel C, LKML, linux-nvme; +Cc: Sagi Grimberg

On 9/11/19 3:21 PM, Gabriel C wrote:
>   Booting with default_ps_max_latency_us >6000 makes the device fail.
>   Also SUBNQN is NULL and gives a warning on each boot/resume.
>    $ nvme id-ctrl /dev/nvme0 | grep ^subnqn
>      subnqn    : (null)
> 
>   I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
>   To be sure is not a Laptop issue only, I tested the device on
>   my server board too with the same results.
>   ( with 2x,4x link on the board and 4x on a PCI-E card ).
> 
>   Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
>   Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

For some reason your commit message is indented. Additionally, your
patch is whitespace damaged. So this won't apply anywhere.

-- 
Jens Axboe


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
  2019-09-11 21:33 ` Jens Axboe
@ 2019-09-11 22:18   ` Gabriel C
  2019-09-11 22:23     ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel C @ 2019-09-11 22:18 UTC (permalink / raw)
  To: Jens Axboe; +Cc: LKML, linux-nvme, Sagi Grimberg

Am Mi., 11. Sept. 2019 um 23:33 Uhr schrieb Jens Axboe <axboe@kernel.dk>:
>
> On 9/11/19 3:21 PM, Gabriel C wrote:
> >   Booting with default_ps_max_latency_us >6000 makes the device fail.
> >   Also SUBNQN is NULL and gives a warning on each boot/resume.
> >    $ nvme id-ctrl /dev/nvme0 | grep ^subnqn
> >      subnqn    : (null)
> >
> >   I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
> >   To be sure is not a Laptop issue only, I tested the device on
> >   my server board too with the same results.
> >   ( with 2x,4x link on the board and 4x on a PCI-E card ).
> >
> >   Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
> >   Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>
> For some reason your commit message is indented. Additionally, your
> patch is whitespace damaged. So this won't apply anywhere.

Gmail hates me it seems. Sry but I don't have an proper setup on that
box right now.
My Laptop died and I try to fix the usual issue for new Laptops on
this one right now.
I uploaded the git patch, if you accept it like this. If not I will
re-send as soon I fix
this laptop and have git* and other things proper set up.

http://crazy.dev.frugalware.org/0001-Added-QUIRKs-for-ADATA-XPG-SX8200-Pro-512GB.patch

Best Regards,

Gabriel C

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
  2019-09-11 22:18   ` Gabriel C
@ 2019-09-11 22:23     ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-09-11 22:23 UTC (permalink / raw)
  To: Gabriel C; +Cc: LKML, linux-nvme, Sagi Grimberg

On 9/11/19 4:18 PM, Gabriel C wrote:
> Am Mi., 11. Sept. 2019 um 23:33 Uhr schrieb Jens Axboe <axboe@kernel.dk>:
>>
>> On 9/11/19 3:21 PM, Gabriel C wrote:
>>>    Booting with default_ps_max_latency_us >6000 makes the device fail.
>>>    Also SUBNQN is NULL and gives a warning on each boot/resume.
>>>     $ nvme id-ctrl /dev/nvme0 | grep ^subnqn
>>>       subnqn    : (null)
>>>
>>>    I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
>>>    To be sure is not a Laptop issue only, I tested the device on
>>>    my server board too with the same results.
>>>    ( with 2x,4x link on the board and 4x on a PCI-E card ).
>>>
>>>    Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
>>>    Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>>
>> For some reason your commit message is indented. Additionally, your
>> patch is whitespace damaged. So this won't apply anywhere.
> 
> Gmail hates me it seems. Sry but I don't have an proper setup on that
> box right now.
> My Laptop died and I try to fix the usual issue for new Laptops on
> this one right now.
> I uploaded the git patch, if you accept it like this. If not I will
> re-send as soon I fix
> this laptop and have git* and other things proper set up.

Use git send-email, it's trivial to use with gmail. That's what I use
and that works fine. If you use gmail (web) for kernel development,
you're going to have a really bad time.

-- 
Jens Axboe


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 21:21 [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB Gabriel C
2019-09-11 21:33 ` Jens Axboe
2019-09-11 22:18   ` Gabriel C
2019-09-11 22:23     ` Jens Axboe

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org linux-nvme@archiver.kernel.org
	public-inbox-index linux-nvme


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/ public-inbox