Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: "George, Martin" <Martin.George@netapp.com>
To: "hch@lst.de" <hch@lst.de>, "hare@suse.de" <hare@suse.de>
Cc: "keith.busch@intel.com" <keith.busch@intel.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"Meneghini, John" <John.Meneghini@netapp.com>
Subject: Re: [PATCH] nvme: Add support for ACRE Command Interrupted status
Date: Tue, 26 Nov 2019 14:48:40 +0000
Message-ID: <863930a5493eb29659ea599e946592fa48423e24.camel@netapp.com> (raw)
In-Reply-To: <20191126133650.72196-1-hare@suse.de>

On Tue, 2019-11-26 at 14:36 +0100, Hannes Reinecke wrote:
> From: John Meneghini <johnm@netapp.com>
> 
> This patch fixes a bug in nvme_complete_rq logic introduced by
> Enhanced Command Retry code. According to TP-4033 the controller
> only sets CDR when the Command Interrupted status is returned.
> The current code interprets Command Interrupted status as a
> BLK_STS_IOERR, which results in a controller reset if
> REQ_NVME_MPATH is set.
> 
> Signed-off-by: John Meneghini <johnm@netapp.com>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/nvme/host/core.c  | 2 ++
>  include/linux/blk_types.h | 1 +
>  include/linux/nvme.h      | 2 ++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 108f60b46804..752a40daf2b3 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -201,6 +201,8 @@ static blk_status_t nvme_error_status(u16 status)
>         switch (status & 0x7ff) {
>         case NVME_SC_SUCCESS:
>                 return BLK_STS_OK;
> +       case NVME_SC_COMMAND_INTERRUPTED:
> +               return BLK_STS_RESOURCE;
>         case NVME_SC_CAP_EXCEEDED:
>                 return BLK_STS_NOSPC;
>         case NVME_SC_LBA_RANGE:
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index d688b96d1d63..3a0d84528325 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -84,6 +84,7 @@ static inline bool blk_path_error(blk_status_t
> error)
>         case BLK_STS_NEXUS:
>         case BLK_STS_MEDIUM:
>         case BLK_STS_PROTECTION:
> +       case BLK_STS_RESOURCE:
>                 return false;
>         }
> 
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index f61d6906e59d..6b21f3888cad 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -1292,6 +1292,8 @@ enum {
> 
>         NVME_SC_NS_WRITE_PROTECTED      = 0x20,
> 
> +       NVME_SC_COMMAND_INTERRUPTED     = 0x21,
> +
>         NVME_SC_LBA_RANGE               = 0x80,
>         NVME_SC_CAP_EXCEEDED            = 0x81,
>         NVME_SC_NS_NOT_READY            = 0x82,
> --
> 2.16.4
> 

Looks good.

Reviewed-by: Martin George <marting@netapp.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 13:36 Hannes Reinecke
2019-11-26 14:48 ` George, Martin [this message]
2019-11-26 16:05 ` Keith Busch
2019-11-26 16:24   ` Christoph Hellwig
2019-11-27 15:29     ` Meneghini, John
2019-11-27 19:08       ` Keith Busch
2019-11-27 19:22         ` Meneghini, John
2019-11-26 16:32   ` Hannes Reinecke
2019-11-27 17:17     ` Meneghini, John

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=863930a5493eb29659ea599e946592fa48423e24.camel@netapp.com \
    --to=martin.george@netapp.com \
    --cc=John.Meneghini@netapp.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git