From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "hch@lst.de" <hch@lst.de>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: clear caller pointer on identify failure
Date: Wed, 6 Mar 2024 17:45:46 +0000 [thread overview]
Message-ID: <90fcd241-8ee3-4ff5-8aea-67fef220bb41@nvidia.com> (raw)
In-Reply-To: <20240306142519.1213814-1-kbusch@meta.com>
On 3/6/2024 6:25 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The memory allocated for the identifification is freed on failure. Set
> it to NULL so the caller doesn't have a pointer to that freed address.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
LGTM.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2024-03-06 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:25 [PATCH] nvme: clear caller pointer on identify failure Keith Busch
2024-03-06 14:27 ` Christoph Hellwig
2024-03-06 17:45 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90fcd241-8ee3-4ff5-8aea-67fef220bb41@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).