linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Keith Busch <keith.busch@wdc.com>,
	Sagi Grimberg <sagi@grimberg.me>
Subject: Re: Case-sensitive host NQN
Date: Thu, 13 Feb 2020 16:38:24 +0100	[thread overview]
Message-ID: <918ac705-7390-900e-7e79-8df71541f266@suse.de> (raw)
In-Reply-To: <20200212175556.GA6014@lst.de>

On 2/12/20 6:55 PM, Christoph Hellwig wrote:
> On Wed, Feb 12, 2020 at 06:51:54PM +0100, Hannes Reinecke wrote:
>> IE we would be perfectly within the spec to convert the nqn to eg lowercase 
>> when reading it from /etc/nvme/hostnqn.
> 
> We could, but why would we?  Case sensitivity is a complete pain and
> avoiding it wherever we can is a good thing.
> 
Because the UUID really is a number, and hence one would assume that it
wouldn't be affected from case sensitivty.

But if the consensus is that we do not twiddle with it we should be
documenting it somewhere (maybe in a comment in the auto-generated
/etc/nvme/hostnqn) so as to avoid surprises or support calls later on.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2020-02-13 15:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 12:58 Case-sensitive host NQN Hannes Reinecke
2020-02-12 17:35 ` Christoph Hellwig
2020-02-12 17:51   ` Hannes Reinecke
2020-02-12 17:55     ` Christoph Hellwig
2020-02-12 19:20       ` Sagi Grimberg
2020-02-13 15:38       ` Hannes Reinecke [this message]
2020-02-13 23:33         ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=918ac705-7390-900e-7e79-8df71541f266@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=keith.busch@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).