Re: [PATCH 17/29] nvmet-fc: Add Disconnect Association Xmt support

[Hannes Reinecke <hare@suse.de>]

On 2/5/20 7:37 PM, James Smart wrote:
> As part of FC-NVME-2 (and ammendment on FC-NVME), the target is to
> send a Disconnect LS after an association is terminated and any
> exchanges for the association have been ABTS'd. The target is also
> not to send the receipt to any Disconnect Association LS, received
> to initiate the association termination or received while the
> association is terminating, until the Disconnect LS has been transmit.
> 
> Add support for sending Disconnect Association LS after all I/O's
> complete (which is after ABTS'd certainly). Utilizes the new LLDD
> api to send ls requests.
> 
> There is no need to track the Disconnect LS response or to retry
> after timeout. All spec requirements will have been met by waiting
> for i/o completion to initiate the transmission.
> 
> Add support for tracking the reception of Disconnect Association
> and defering the response transmission until after the Disconnect
> Association LS has been transmit.
> 
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>  drivers/nvme/target/fc.c | 298 +++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 287 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
> index d52393cd29f7..3e94c4909cf9 100644
> --- a/drivers/nvme/target/fc.c
> +++ b/drivers/nvme/target/fc.c
> @@ -25,7 +25,7 @@
>  struct nvmet_fc_tgtport;
>  struct nvmet_fc_tgt_assoc;
>  
> -struct nvmet_fc_ls_iod {
> +struct nvmet_fc_ls_iod {		// for an LS RQST RCV
>  	struct nvmefc_ls_rsp		*lsrsp;
>  	struct nvmefc_tgt_fcp_req	*fcpreq;	/* only if RS */
>  
> @@ -45,6 +45,18 @@ struct nvmet_fc_ls_iod {
>  	struct work_struct		work;
>  } __aligned(sizeof(unsigned long long));
>  
> +struct nvmet_fc_ls_req_op {		// for an LS RQST XMT
> +	struct nvmefc_ls_req		ls_req;
> +
> +	struct nvmet_fc_tgtport		*tgtport;
> +	void				*hosthandle;
> +
> +	int				ls_error;
> +	struct list_head		lsreq_list; /* tgtport->ls_req_list */
> +	bool				req_queued;
> +};
> +
> +
>  /* desired maximum for a single sequence - if sg list allows it */
>  #define NVMET_FC_MAX_SEQ_LENGTH		(256 * 1024)
>  
Please, use normal comments, not C++-style // thingies.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme