Re: nvmetcli: Unable to run clear/restore

[Tony Asleson <tasleson@redhat.com>]

On 3/20/20 3:50 PM, Tony Asleson wrote:
> While experimenting with nvmetcli I'm unable to run clear or restore.
> 
> Using master branch against Fedora 31, 5.5.9-200.fc31.x86_64
> 
> # ./nvmetcli clear
> Traceback (most recent call last):
>   File "./nvmetcli", line 740, in <module>
>     main()
>   File "./nvmetcli", line 722, in main
>     funcs[sys.argv[1]](savefile)
>   File "./nvmetcli", line 689, in clear
>     nvme.Root().clear_existing()
>   File "/root/projects/nvmetcli/nvmet/nvme.py", line 315, in clear_existing
>     p.delete()
>   File "/root/projects/nvmetcli/nvmet/nvme.py", line 677, in delete
>     a.delete()
>   File "/root/projects/nvmetcli/nvmet/nvme.py", line 200, in delete
>     os.rmdir(self.path)
> PermissionError: [Errno 1] Operation not permitted:
> '/sys/kernel/config/nvmet/ports/0/ana_groups/1'

Apparently if I simply do

# rmdir /sys/kernel/config/nvmet/ports/1

The port and associated ana group gets removed and the usage count for
the kernel module nvmet goes to zero.

Is the bug that we are trying to remove
/sys/kernel/config/nvmet/ports/0/ana_groups/1 in userspace from nvmetcli
which can simply be corrected with

diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index 089bafb..a2565e4 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -686,8 +686,6 @@ class Port(CFSNode):
         self._check_self()
         for s in self.subsystems:
             self.remove_subsystem(s)
-        for a in self.ana_groups:
-            a.delete()


or that we should be able to remove it and can't, thus the issue is in
the kernel?

Thanks,
Tony


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme