Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: "Wunderlich, Mark" <mark.wunderlich@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: RE: [PATCH] 2/2] nvmet-tcp: set SO_PRIORITY for accepted sockets
Date: Thu, 7 Nov 2019 16:39:13 +0000
Message-ID: <B33B37937B7F3D4CB878107E305D4916D4E95F@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <7f963f1c-d15a-58cb-ca9e-4c3914038a82@grimberg.me>


>Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

>We could do this with configfs, but it given that this is very much specific to tcp transport I find it hard to justify.

Assume we will discuss more when re-posting in new series.  Agree there are various location options to define so_priority.  Options considered in the past being:
- Just make it a module define to specific value (say 1) that is only leveraged if busy polling enabled.
- Make it a sysctl variable, like sysctl_net_busy_poll and sysctl_net_busy_read that are related to busy polling, and again only leverage it if busy polling enabled.
- Or, as shown in this patch, where it was suggested that a module parameter is preferable over use of sysctl.
- And as you indicate, configfs.  Given this is more specific to adjusting tcp sockets behavior, use of configfs did not seem right.

If there is a preference, would be happy to adjust before re-posting of the patches.

Cheers --- Mark
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 22:27 Wunderlich, Mark
2019-11-06 16:45 ` Sagi Grimberg
2019-11-07 16:39   ` Wunderlich, Mark [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B33B37937B7F3D4CB878107E305D4916D4E95F@ORSMSX104.amr.corp.intel.com \
    --to=mark.wunderlich@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git