From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CD7C43331 for ; Thu, 7 Nov 2019 16:39:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29FEE206DF for ; Thu, 7 Nov 2019 16:39:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dKGa/xme" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29FEE206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JoEx5R6aNY1uHYInDDROGdm72HFjrNpd2rs2t7F4MIA=; b=dKGa/xmeeF0r6O ltM5eclzH9DlGyG6V20cYOIN7er/7SIsdrLYXiimsWKYNi7lAAGOP+TAxETYDsPYrlhR/+7Euxnfy UcqJjCBuqn3f9mxJGvFBrczlHpumodLm4IQVBhM8pvPfwMgJtmduwXFAEe4EzSCh6Sl/XXxfaIMir rI+9R/nTuQTS+eVuW0GR1cWL1MtSGD39SSoXQnyiA1CS6bjxGFiwXCcD3IojzC4b/UqEvMjqYnAZj S7vgfMpyyXvMgqC4brYI/xznWQGIgbF0hI669vzOCQZdhOigfsxpKSQ1iqa1k9kSC+f5hJg59cYpO WFQon55IfvVQc1tDgTmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSkob-0003Z7-MT; Thu, 07 Nov 2019 16:39:21 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSkoW-0003Yf-GJ for linux-nvme@lists.infradead.org; Thu, 07 Nov 2019 16:39:20 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 08:39:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,278,1569308400"; d="scan'208";a="286038222" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga001.jf.intel.com with ESMTP; 07 Nov 2019 08:39:14 -0800 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.167]) by ORSMSX107.amr.corp.intel.com ([169.254.1.115]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 08:39:14 -0800 From: "Wunderlich, Mark" To: Sagi Grimberg , "linux-nvme@lists.infradead.org" Subject: RE: [PATCH] 2/2] nvmet-tcp: set SO_PRIORITY for accepted sockets Thread-Topic: [PATCH] 2/2] nvmet-tcp: set SO_PRIORITY for accepted sockets Thread-Index: AdWPcIWvzHpFj0a7RH6PLL2mIs1EQAFlCrCAACDUgpA= Date: Thu, 7 Nov 2019 16:39:13 +0000 Message-ID: References: <7f963f1c-d15a-58cb-ca9e-4c3914038a82@grimberg.me> In-Reply-To: <7f963f1c-d15a-58cb-ca9e-4c3914038a82@grimberg.me> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjFiZTBlODktMDE5Ni00MTIxLWJiMDQtZjQ0ZDZkNjZhNWM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWWpuK05cL0xTS2w4VnlUcEo5S2I2UXlncjRLQk5cL1FUSFg4UDF0Vmt4R0thXC8rVUttWWpRRDUza0xcL3ByNmZTUmIifQ== x-originating-ip: [10.22.254.139] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_083918_918498_94D88109 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org >Reviewed-by: Sagi Grimberg >We could do this with configfs, but it given that this is very much specific to tcp transport I find it hard to justify. Assume we will discuss more when re-posting in new series. Agree there are various location options to define so_priority. Options considered in the past being: - Just make it a module define to specific value (say 1) that is only leveraged if busy polling enabled. - Make it a sysctl variable, like sysctl_net_busy_poll and sysctl_net_busy_read that are related to busy polling, and again only leverage it if busy polling enabled. - Or, as shown in this patch, where it was suggested that a module parameter is preferable over use of sysctl. - And as you indicate, configfs. Given this is more specific to adjusting tcp sockets behavior, use of configfs did not seem right. If there is a preference, would be happy to adjust before re-posting of the patches. Cheers --- Mark _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme