From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
SelvaKumar S <selvakuma.s1@samsung.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"kch@kernel.org" <kch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"selvajove@gmail.com" <selvajove@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nj.shetty@samsung.com" <nj.shetty@samsung.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"javier.gonz@samsung.com" <javier.gonz@samsung.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"joshiiitr@gmail.com" <joshiiitr@gmail.com>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [RFC PATCH v5 0/4] add simple copy support
Date: Sat, 10 Apr 2021 00:29:59 +0000 [thread overview]
Message-ID: <BYAPR04MB49652982D00724001AE758C986729@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: b56a18a0-facc-edb3-c809-7436f1b1c15a@nvidia.com
On 4/9/21 17:22, Max Gurtovoy wrote:
> On 2/19/2021 2:45 PM, SelvaKumar S wrote:
>> This patchset tries to add support for TP4065a ("Simple Copy Command"),
>> v2020.05.04 ("Ratified")
>>
>> The Specification can be found in following link.
>> https://nvmexpress.org/wp-content/uploads/NVM-Express-1.4-Ratified-TPs-1.zip
>>
>> Simple copy command is a copy offloading operation and is used to copy
>> multiple contiguous ranges (source_ranges) of LBA's to a single destination
>> LBA within the device reducing traffic between host and device.
>>
>> This implementation doesn't add native copy offload support for stacked
>> devices rather copy offload is done through emulation. Possible use
>> cases are F2FS gc and BTRFS relocation/balance.
>>
>> *blkdev_issue_copy* takes source bdev, no of sources, array of source
>> ranges (in sectors), destination bdev and destination offset(in sectors).
>> If both source and destination block devices are same and copy_offload = 1,
>> then copy is done through native copy offloading. Copy emulation is used
>> in other cases.
>>
>> As SCSI XCOPY can take two different block devices and no of source range is
>> equal to 1, this interface can be extended in future to support SCSI XCOPY.
> Any idea why this TP wasn't designed for copy offload between 2
> different namespaces in the same controller ?
Yes, it was the first attempt so to keep it simple.
Further work is needed to add incremental TP so that we can also do a copy
between the name-spaces of same controller (if we can't already) and to the
namespaces that belongs to the different controller.
> And a simple copy will be the case where the src_nsid == dst_nsid ?
>
> Also why there are multiple source ranges and only one dst range ? We
> could add a bit to indicate if this range is src or dst..
>
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-10 0:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210219124555epcas5p1334e7c4d64ada5dc4a2ca0feb48c1d44@epcas5p1.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 0/4] add simple copy support SelvaKumar S
[not found] ` <CGME20210219124559epcas5p41da46f1c248e334953d407a154697903@epcas5p4.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 1/4] block: make bio_map_kern() non static SelvaKumar S
[not found] ` <CGME20210219124603epcas5p33add0f2c1781b2a4d71bf30c9e1ac647@epcas5p3.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 2/4] block: add simple copy support SelvaKumar S
2021-02-20 4:59 ` Damien Le Moal
2021-04-07 11:32 ` Selva Jove
2021-04-12 0:24 ` Damien Le Moal
2021-04-12 14:34 ` Selva Jove
2021-04-13 0:32 ` Damien Le Moal
2021-04-14 6:58 ` Selva Jove
[not found] ` <CGME20210219124608epcas5p2a673f9e00c3e7b5352f115497b0e2d98@epcas5p2.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 3/4] nvme: " SelvaKumar S
2021-02-20 3:36 ` Matthew Wilcox
2021-02-22 15:57 ` Selva Jove
[not found] ` <CGME20210219124611epcas5p1c775b63b537e75da161556e375fcf05e@epcas5p1.samsung.com>
2021-02-19 12:45 ` [RFC PATCH v5 4/4] dm kcopyd: add simple copy offload support SelvaKumar S
2021-02-20 18:01 ` [RFC PATCH v5 0/4] add simple copy support David Laight
2021-02-20 19:08 ` Matthew Wilcox
2021-02-20 19:19 ` Keith Busch
2021-02-21 23:52 ` Dave Chinner
2021-02-23 9:14 ` Selva Jove
2021-02-22 1:31 ` Ming Lei
2021-02-22 6:52 ` Su Yue
2021-02-23 9:00 ` Selva Jove
2021-04-10 0:21 ` Max Gurtovoy
2021-04-10 0:29 ` Chaitanya Kulkarni [this message]
2021-04-10 6:32 ` Javier González
2021-04-11 9:10 ` Max Gurtovoy
2021-04-11 19:26 ` Javier González
2021-04-13 15:38 ` Max Gurtovoy
2021-04-13 18:25 ` Javier González
2021-04-13 18:36 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB49652982D00724001AE758C986729@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=kch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=selvajove@gmail.com \
--cc=selvakuma.s1@samsung.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).