From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E70C433ED for ; Thu, 15 Apr 2021 23:48:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 621CE610FB for ; Thu, 15 Apr 2021 23:48:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 621CE610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date:Subject:CC: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=0c/LqAvbbUNIC3oEdjVJiCYBPj8m78BMDmnQLFqGUUU=; b=pCvcaYLeRuPrjy1/MAAwpNF4Y Ws2+aMi3eYYWlNfcL+xRb1bau53DY2TIpsu7mAt5XxnOWgg+wfHzO3Rd6R+JFnjohyjgK6yKa6BIj v1MN6txdFtt7nCpo3m+07MSCr02ADR2e1y0XFGp9P/jcM7wnHHgRytQjH1vIrF61mooc9xOGx9T6m S3bi+fQErjm2Foqevby/E8ahEQ22lvUPPttbZOzIO38DYuiUy909FPmk6m2Ib+4PmfAx+N2W0+fm1 KXDZCQ4tMJjHaawH2xU5IVFBeZpmJLlgKmCzvmTZdi2SR/Q8cCX4ilefJhSc1PosSGeirAFyO8BT+ yseDD0Z4g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXBiZ-0008w3-9H; Thu, 15 Apr 2021 23:48:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXBiW-0008ue-8r for linux-nvme@desiato.infradead.org; Thu, 15 Apr 2021 23:48:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:References:Message-ID:Date:Subject:CC: To:From:Sender:Reply-To:Content-ID:Content-Description:In-Reply-To; bh=QK0XeYrxiMiSinri4syoe3hm2Am4tQIP2u4dZP65aUE=; b=ooNLK6+9w5CPeGAUcT4YB7zqh5 DVbjEj3V/mRcDTSUkN0NFdaAZFIcCNvAhPi9CGtgVx2/ov8DyARfvHZvRSA7P203PBB2d2m49ZRBd QZbgmPF5V0retqnljKl64WkeBqEvVYctK6IfezJv+rvZ22v/QQ0wPvl6VjvNivM0B1g8UAsTkKDLH yuLdQFXykNQXgifsW+xx+/YW2XAnp0uLHCpcobAosk0pzUWvctAInuD2cCsxvnJwjyW8SejOveN8i jxE0jVaG2GTe+cdQYaAKqvrlogB86h/hYsNctJEyP4Lf3esyoHfXHDdw2XVZIJ7rO95gj4TcNZt6w awVtbzDg==; Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXBiT-008z58-4F for linux-nvme@lists.infradead.org; Thu, 15 Apr 2021 23:48:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618530488; x=1650066488; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=QK0XeYrxiMiSinri4syoe3hm2Am4tQIP2u4dZP65aUE=; b=BoZs5F5BEyfYkDTv0z2JOf8WT1aWFv+ploHOvRKVhhMvA751OcpW11nR +OV41GvZgkR6poSdXluqyOMvwf/3Oy3UdMjyTjMnFdT8sC8AD7QED1vQ4 vhcKfhyu6fDbtgE8DNqsTzAySR5HH6zF/Nmi35O5jdord3pq4l0g7wflW NflEhmdgBAYK74dooft+ds7pmZIjBIMwdnYcff1eeOgeUaDxoX7D5jc0V 6Iw7Z2dT2042aRL2iUKpK0Qq00r6qIny1HWAOb+5AVooyRGN7cH3uUHui 9wcWbx1WO+qyma3DRb0AMUxMiIL9/Fv/aKAnrIKPHpkAsrx6Sr8d1xIxd Q==; IronPort-SDR: vwnR6rezXMXlLArA86Q2Th1XA1FIiw/U3SEz4+S0+rec/NyTiRcGq5TZDCKU9IXQPE4GYoulSk saAa+GcTlQ13g9MtcZfXUMRwAZX9D1igetBnNbslRRd3/qEA9Up5Jf8Uvd9KqSrCRjfn34u2Lj HkfytgVdSirVjEFCmQjetNUcygXAI/AzBG96dhA0PTY+SM+b3NCUvmamHde59YfyHF0/Qj6ntv DXxA5vJ9nEGcMF9fx3uNuVE0Yok/ZBuyAq+JhFtcuPRLFK2Pp4rprnco3WaXZg8WYTVB1/WltR Olw= X-IronPort-AV: E=Sophos;i="5.82,226,1613404800"; d="scan'208";a="164988423" Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hgst.iphmx.com with ESMTP; 16 Apr 2021 07:48:04 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1CApp3fjNK1fi6tP1ueaxyyZSjIDmxU7fmf7mvvhmQL+m6MGYlok9A9C3mDTF0zOCDlZo4UYAY2K9s1PUuYqJxQBHo5bRfeJyWKj67qBvjJc+dEWdVH9CkWnL8mStQTN72OP44qC3rf3nnd+jG5Lfe+DeGfihr78VXruydwGYd4z8FssHyW+VzMIvNWHuigP6AIq/M5YCvX6D8Fhxg774MjAlo6YEtgMqtC4GOMQWYj5IH0OLYFSfugpA5MNw8X2Lp1jDcWwa1qQ+Bzv59jeAlgIsh5WThsf9VGt8bdZviLKQ4VF+FBcmw45/P8HmLIonwaqu6itIPhFhOQW4ID8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QK0XeYrxiMiSinri4syoe3hm2Am4tQIP2u4dZP65aUE=; b=l9aHg8/Of2lVYIhloHMfi282Xerh4h4vpFu/ncDekg2/rn+11J2dHaYEm54XOL0qmFbxwnrtbYUNdfpvAg0mGu9bxi7G0O2TtrKbB930ZhZRVHboVcequ0RY/eK25VMgo/wqw9erCz6JOD+/kQhM3HNkzgsrDeTcyrKCTxctnPjCgMbqAFk3+6B0bHiwCjTau5ol2tVWJPvoX5Ide/E5puUK7l2vzoyEZdHsHPne6oJfnWfkoTSklPjtGlnJu/KXm+J4kyTp9KMRfFpxx8TPYWTSzQLq9hEGfTVprp0Bkc5z8taiNlDgRpvhND/pJk7cxj7MB5weRM44/ZPrIq3cBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QK0XeYrxiMiSinri4syoe3hm2Am4tQIP2u4dZP65aUE=; b=rU1r5JC1UnqxATQUMb+R/JkauVQCecdIDz6yUaHL2+U1lnb7x6Am62DovSvduZnQtKmESiR7odCCBKE8L8441ofPU2kXXILGptFC5Z2g/7ovJy4WEABzpcEHMjrY4ZiuymzbqeUA8F5hi5xUc+yczRi7f56UUqZjnC92xMONiCM= Received: from BYAPR04MB4965.namprd04.prod.outlook.com (2603:10b6:a03:4d::25) by BYAPR04MB4232.namprd04.prod.outlook.com (2603:10b6:a02:fd::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 23:48:02 +0000 Received: from BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::c897:a1f8:197a:706b]) by BYAPR04MB4965.namprd04.prod.outlook.com ([fe80::c897:a1f8:197a:706b%5]) with mapi id 15.20.4020.023; Thu, 15 Apr 2021 23:48:02 +0000 From: Chaitanya Kulkarni To: Mike Snitzer , Christoph Hellwig , Jens Axboe CC: "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" Subject: Re: [PATCH v2 1/4] nvme: return BLK_STS_DO_NOT_RETRY if the DNR bit is set Thread-Topic: [PATCH v2 1/4] nvme: return BLK_STS_DO_NOT_RETRY if the DNR bit is set Thread-Index: AQHXMk7X6k16GPe6nE2qzRxrTa/DAw== Date: Thu, 15 Apr 2021 23:48:01 +0000 Message-ID: References: <20210415231530.95464-1-snitzer@redhat.com> <20210415231530.95464-2-snitzer@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [199.255.45.62] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d8d3a3c3-a8a4-4803-7b59-08d90068e819 x-ms-traffictypediagnostic: BYAPR04MB4232: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lwtrp4qj2Y96mDzU7j1bdcxxWdvXWgsXYAPcfBm3Gff+4NHjxwTRn+/EwtShzLx76j3krtGlBPwNO8TWgGY2Q3pgn5RhRuIaU/ZMRPiz9z9qr0sKrXli5YzqC5l+zavXy43/wNfGQJgXP5lQP8EezILQvWmTNT/rC8t0ckLeawm3chlTOiq2RVvIY5tvPR8JgZa5L+AGz6mOSdcQzM4B10nbYxhnAvPWhT8A1UCzI5vnZcVGjkwTPu4JNvQtxLRiwcQqiDd1q1TAalxgXNqHkk4yqt92Qv+aQXNisO5IaxtTTlg9KFPHke47p5LNei4DwnKbiZ8VbY6MW5jMzSNgLY1S9FScP31SHqN9C5l3SFeq/Vt9TBNbu3dBuBPw33Gwc24CKF/C7lyLYWB11WgAURUaizkfU6HOCGaIOhl3hREa3seiydMmUpKquZ7OYw+1LvtCf/ASnqGjrNYAuJiHerl86oJ3/gav/f7VnmdmorzH5GOno9VEP59Vo4aeb4O2e/lmIRlyxAA3vL6YfI97jFUBQr20Oq86QoFgguoEHpzxFdTSrtkrnswM5w3s3jqewmaUXN9EFjWhqtVmMHwso55qAonxrVOdQE6etZ77OTE1W/mYpa3V0nZFGSySGbM/XGJxPCI38SXNetsUABnjO3UPDD7DTalxR3JSHvsRjsIwpu0NgN6DGx/N9TBqsCkE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR04MB4965.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(366004)(346002)(39860400002)(396003)(9686003)(26005)(76116006)(86362001)(66946007)(53546011)(55016002)(110136005)(122000001)(186003)(478600001)(5660300002)(54906003)(64756008)(4326008)(52536014)(66476007)(4744005)(66446008)(66556008)(7696005)(316002)(8676002)(71200400001)(8936002)(966005)(38100700002)(83380400001)(2906002)(6506007)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?shNcMjpazFA3jqj1+XxoU2E1Bg15+afozS+Vmyhffq0WRLiIDbiuteGl0N3A?= =?us-ascii?Q?jB0wBw0NkSj5YbyzPsiYKsgyUkOf8hF4lc+iGehgR834IzlxR/58s/VphWx0?= =?us-ascii?Q?TELq686OXTJxHGcffcEHJMjyVE2HSNezDVeynByZDVqzDSO4v0KJLlmvojNl?= =?us-ascii?Q?ssAG/yTPa7yPw5bINykCyN4KdJDx9ge8bFwvlzjA0e0C/bDnwwsG0Br/5Zul?= =?us-ascii?Q?3ELezF/pMMOeBsME6/mSAGAJgZlKzZdEdJF7FD4x+FsNUYSyuxA6I9svRCTC?= =?us-ascii?Q?NLpVv2jx6xoe+B0SJEBLCUA+MYJCU/RFfC6kciXFZuSZs1I3VV+2fBmyTUks?= =?us-ascii?Q?WMujKrzw9y3hOWgWqdLMPyTHeXJsF1G9KacoexovDujb44U4Hq5Bmw8ViSM2?= =?us-ascii?Q?tPdUTE12YOAoemYhMMo1FLgVhAB77r4nprerNERiCm5lbGC1ZTu0PrSGVTRJ?= =?us-ascii?Q?x8vOnVMEs60RTNYhlQ4Xi9var4fYjlzK1RKeQKkEem6NWajwuHHgujZd3teF?= =?us-ascii?Q?lE2lBLxttYhKhBbYGJXSQwmXJNT8YrBSwYYjaP9GB+tFCAJXJSHDnwf5nTDB?= =?us-ascii?Q?atE0L/XMPGFUmRQxPyFRmbcKCahfB4TSCDeGaEVFvHDEKumnai1pmahFfyvo?= =?us-ascii?Q?OJKAXLoN5yKJOWEWA9VNdpBbO9eoRpPFCSWYOtUx3OigXNgAJdUGKOxYN6eD?= =?us-ascii?Q?aEzpJzCxot4l/V6QbX+6By3dAuMC4CtCM+JhG6LCKS6R0ujiN6B2KSB+rgap?= =?us-ascii?Q?1BYq8dWEVJScu+OHDkx7TSsC+bYy6hBdLh9zg5AiyltE0U9zQvU8Spsolanw?= =?us-ascii?Q?S02OdKmkPiJyFUsmn1pug+CLEM4rCAxfow0gM5KWmpECrWX8gSHXGNs7kLSj?= =?us-ascii?Q?0+yTixXD6h7e51NPjhq70yhx6SRyo8meUnzAN253+CxBx1MGm5vCD2LQVYlf?= =?us-ascii?Q?lQ2a4a3/h0M40GtLFxHIq0llAL57NFB5CzPxaBM/Pf+dBtX7bMdLpUYVCTqW?= =?us-ascii?Q?ZLgyx/aT8xio68A0AfUWar8bLr2tvL4vxhPCamg2awJZ2TLa4DsjZvQYJgSi?= =?us-ascii?Q?P7ky0AgQuQ5n0hql1CnfoAQH4HfZZINoWj1usXI8v5mHBRlpUIm0V8hTDHqj?= =?us-ascii?Q?Un8nuU6B3FUEWis796sHUGY428DSQFf6F8hHxftsd2QvK9EXRWXLljpCDAH6?= =?us-ascii?Q?bopw5S1cYNHy0GXTZQwWfNy5DVOTzPvpMzoMeQhUY3KaDVft3uPXkh+14jDF?= =?us-ascii?Q?ro15IMnH+pStKvIpT0scu+uo6ZrXf/7CfPCvOC4Mwkh0F+ZLlWkOsdCNyrf6?= =?us-ascii?Q?RcvStvtI6Cx3bSp5mthiwBOk?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR04MB4965.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8d3a3c3-a8a4-4803-7b59-08d90068e819 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 23:48:01.8269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R41h1+4oHoTdDS8bRi6iZw8FRvzqIx+1gttR2H99J9O2vRTvbcY3j+sNS0KnaAjsR2XCy9vmoOS0SMB2a88oXOk3rhyXe8dxttziVuV7OaA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4232 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_164809_203317_6C07B5D2 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 4/15/21 16:27, Mike Snitzer wrote: > If the DNR bit is set we should not retry the command. > > We care about the retryable vs not retryable distinction at the block > layer so propagate the equivalent of the DNR bit by introducing > BLK_STS_DO_NOT_RETRY. Update blk_path_error() to _not_ retry if it > is set. > > This change runs with the suggestion made here: > https://lore.kernel.org/linux-nvme/20190813170144.GA10269@lst.de/ > > Suggested-by: Christoph Hellwig > Signed-off-by: Mike Snitzer Looks good. Reviewed-by: Chaitanya Kulkarni _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme