From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
"james.smart@broadcom.com" <james.smart@broadcom.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"james_p_freyensee@linux.intel.com"
<james_p_freyensee@linux.intel.com>
Cc: "tianjia.zhang@alibaba.com" <tianjia.zhang@alibaba.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()
Date: Sun, 2 Aug 2020 22:54:48 +0000 [thread overview]
Message-ID: <BYAPR04MB4965A8EF12A48FF2418B6D92864C0@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200802111545.5566-1-tianjia.zhang@linux.alibaba.com
On 8/2/20 04:22, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport")
> Cc: James Smart<jsmart2021@gmail.com>
> Signed-off-by: Tianjia Zhang<tianjia.zhang@linux.alibaba.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-02 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 11:15 [PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request() Tianjia Zhang
2020-08-02 22:54 ` Chaitanya Kulkarni [this message]
2020-08-14 8:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965A8EF12A48FF2418B6D92864C0@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=jthumshirn@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tianjia.zhang@alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).