From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"hch@lst.de" <hch@lst.de>, "oren@nvidia.com" <oren@nvidia.com>,
"ngottlieb@nvidia.com" <ngottlieb@nvidia.com>
Subject: Re: [PATCH 1/4] nvmet: change sn size and check validity
Date: Thu, 22 Apr 2021 19:11:56 +0000 [thread overview]
Message-ID: <BYAPR04MB4965DDF464B5C48961CF6C1B86469@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: bd1e5f26-8eda-d784-ff00-686190ed68b4@nvidia.com
On 4/22/21 01:50, Max Gurtovoy wrote:
>>> -/* See Section 1.5 of NVMe 1.4 */
>>> -static bool nvmet_is_ascii(const char c)
>>> -{
>>> - return c >= 0x20 && c <= 0x7e;
>>> -}
>>> -
>>> static ssize_t nvmet_subsys_attr_model_store_locked(struct nvmet_subsys *subsys,
>>> const char *page, size_t count)
>>> {
>>> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
>>> index adbede9ab7f3..3efd48b0a34e 100644
>>> --- a/drivers/nvme/target/core.c
>>> +++ b/drivers/nvme/target/core.c
>>> @@ -1482,6 +1482,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn,
>>> enum nvme_subsys_type type)
>>> {
>>> struct nvmet_subsys *subsys;
>>> + char serial[NVMET_SN_MAX_SIZE / 2];
>> This needs a comment why NVMET_SN_MAX_SIZE / 2.
> explain bin2hex ?
>
>
I'm not sure, I'll leave it to Christoph and Sagi.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-22 19:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 9:09 [PATCH 1/4] nvmet: change sn size and check validity Max Gurtovoy
2021-04-20 9:09 ` [PATCH 2/4] nvmet: make sn stable once connection was established Max Gurtovoy
2021-04-20 9:09 ` [PATCH 3/4] nvmet: allow mn change if subsys not discovered Max Gurtovoy
2021-04-20 9:09 ` [PATCH 4/4] nvmet: make ver stable once connection established Max Gurtovoy
2021-04-20 17:47 ` Chaitanya Kulkarni
2021-04-22 8:43 ` Max Gurtovoy
2021-04-22 19:01 ` Chaitanya Kulkarni
2021-04-20 17:35 ` [PATCH 1/4] nvmet: change sn size and check validity Chaitanya Kulkarni
2021-04-22 8:50 ` Max Gurtovoy
2021-04-22 19:11 ` Chaitanya Kulkarni [this message]
2021-04-23 15:51 ` Keith Busch
2021-04-26 13:15 ` Max Gurtovoy
2021-04-29 10:47 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965DDF464B5C48961CF6C1B86469@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgurtovoy@nvidia.com \
--cc=ngottlieb@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).