linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Stephen Bates <sbates@raithlin.com>, Jens Axboe <axboe@fb.com>,
	Keith Busch <kbusch@kernel.org>, Max Gurtovoy <maxg@mellanox.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v15 7/9] nvmet-passthru: Add passthru code to process commands
Date: Mon, 20 Jul 2020 21:58:29 +0000	[thread overview]
Message-ID: <BYAPR04MB4965E4374C4A99F326507A88867B0@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 5cc390cf-9b0b-b48b-7447-37934be51ee0@deltatee.com

On 7/20/20 14:41, Logan Gunthorpe wrote:
>> That is a neat idea! should be easy to do (and we can then lose the host
>> xarray stuff). I don't mind having it on a later patch, but it should be
>> easy enough to do even before...
>>
> I sort of follow this. I can try to work something up but it will
> probably take me a few iterations to get it to where you want it. So,
> roughly, we'd create a passthrough_q in core with the controller's IO
> tagset and then cleanup the fabrics hosts to use that instead of each
> independently creating their connect_q?
> 
> Though, I don't understand how this relates to the host xarray stuff
> that Sagi mentioned...

I didn't understand it either how having a passthru q can get rid of the
struct nvme_ns search when nsid is embedded in the nvme_cmd in
the I/O path ?

Sagi can you please explain ?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-07-20 21:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 20:33 [PATCH v15 0/9] nvmet: add target passthru commands support Logan Gunthorpe
2020-07-16 20:33 ` [PATCH v15 1/9] nvme-core: Clear any SGL flags in passthru commands Logan Gunthorpe
2020-07-20 14:01   ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 2/9] nvme: Create helper function to obtain command effects Logan Gunthorpe
2020-07-20 14:04   ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper Logan Gunthorpe
2020-07-20 14:06   ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 4/9] nvmet-passthru: Introduce NVMet passthru Kconfig option Logan Gunthorpe
2020-07-20 14:06   ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Logan Gunthorpe
2020-07-20 14:09   ` Christoph Hellwig
2020-07-16 20:33 ` [PATCH v15 6/9] nvme: Export existing nvme core functions Logan Gunthorpe
2020-07-16 20:33 ` [PATCH v15 7/9] nvmet-passthru: Add passthru code to process commands Logan Gunthorpe
2020-07-20 14:16   ` Christoph Hellwig
2020-07-20 19:35     ` Sagi Grimberg
2020-07-20 21:41       ` Logan Gunthorpe
2020-07-20 21:58         ` Chaitanya Kulkarni [this message]
2020-07-20 22:35         ` Sagi Grimberg
2020-07-20 23:01           ` Logan Gunthorpe
2020-07-20 23:15             ` Sagi Grimberg
2020-07-20 23:17             ` Keith Busch
2020-07-20 23:28               ` Sagi Grimberg
2020-07-21  0:06                 ` Keith Busch
2020-07-21  0:39                   ` Sagi Grimberg
2020-07-22 21:09           ` Logan Gunthorpe
2020-07-22 22:31             ` Sagi Grimberg
2020-07-16 20:33 ` [PATCH v15 8/9] nvmet-passthru: Add enable/disable helpers Logan Gunthorpe
2020-07-16 20:33 ` [PATCH v15 9/9] nvmet-configfs: Introduce passthru configfs interface Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB4965E4374C4A99F326507A88867B0@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).