From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 3/5 blktests] nvme: allow target subsys set model
Date: Fri, 14 Feb 2020 01:11:08 +0000 [thread overview]
Message-ID: <BYAPR04MB57490C8BCDC4A7828807C01986150@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200211220003.GD100751@vader
On 02/11/2020 02:00 PM, Omar Sandoval wrote:
>> fi
> It's not in the git diff context, but the line above is
>
> if [ $# -eq 5 ] && [ -f ${cfs_path}/attr_cntlid_min ]; then
>
> So if we pass 6 arguments, the cntlid arguments are ignored? These
> checks should probably be -ge
>
With the -ge change it will also print wrong skip reason for 034
I remember now I think that is the reason why kept it -eq :-
Here is with -ge :-
blktests (master) # ./check tests/nvme/033
nvme/033 (Test NVMeOF target cntlid[min|max] attributes) [not run]
attr_cntlid_[min|max] not found
blktests (master) # ./check tests/nvme/034
nvme/034 (Test NVMeOF target model attribute) [not run]
attr_cntlid_[min|max] not found
With -eq :-
blktests (master) # ./check tests/nvme/033
nvme/033 (Test NVMeOF target cntlid[min|max] attributes) [not run]
attr_cntlid_[min|max] not found
blktests (master) # ./check tests/nvme/034
nvme/034 (Test NVMeOF target model attribute) [not run]
attr_model not found
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-14 1:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 23:29 [PATCH 0/5 blktest] nvme: add cntlid and model testcases Chaitanya Kulkarni
2020-01-29 23:29 ` [PATCH 1/5 blktests] nvme: allow target subsys set cntlid min/max Chaitanya Kulkarni
2020-02-11 21:50 ` Omar Sandoval
2020-01-29 23:29 ` [PATCH 2/5 blktests] nvme: test target cntlid min cntlid max Chaitanya Kulkarni
2020-02-11 21:58 ` Omar Sandoval
2020-01-29 23:29 ` [PATCH 3/5 blktests] nvme: allow target subsys set model Chaitanya Kulkarni
2020-02-11 22:00 ` Omar Sandoval
2020-02-14 0:58 ` Chaitanya Kulkarni
2020-02-14 1:11 ` Chaitanya Kulkarni [this message]
2020-01-29 23:29 ` [PATCH 4/5 blktests] nvme: test target model attribute Chaitanya Kulkarni
2020-02-11 22:04 ` Omar Sandoval
2020-01-29 23:29 ` [PATCH 5/5 blktests] nvme: make new testcases backward compatible Chaitanya Kulkarni
2020-02-11 22:06 ` Omar Sandoval
2020-02-11 22:18 ` Chaitanya Kulkarni
2020-02-03 22:48 ` [PATCH 0/5 blktest] nvme: add cntlid and model testcases Chaitanya Kulkarni
2020-02-11 16:46 ` Chaitanya Kulkarni
2020-02-11 22:07 ` Omar Sandoval
2020-02-11 22:17 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57490C8BCDC4A7828807C01986150@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).