Linux-NVME Archive on
 help / color / Atom feed
From: Chaitanya Kulkarni <>
To: Andy Shevchenko <>,
	Keith Busch <>, Jens Axboe <>,
	"" <>,
	Christoph Hellwig <>, Sagi Grimberg <>
Cc: Benjamin Herrenschmidt <>
Subject: Re: [PATCH v1] nvme-pci: Move enumeration by class to be last in the table
Date: Mon, 24 Feb 2020 10:55:11 +0000
Message-ID: <> (raw)
In-Reply-To: <>

Looks good.

Reviewed-by: Chaitanya Kulkarni <>

On 2/24/20 1:55 AM, Andy Shevchenko wrote:
> It's unusual that we have enumeration by class in the middle of the table.
> It might potentially be problematic in the future if we add another entry
> after it.
> So, move class matching entry to be the last in the ID table.
> While here, group Apple devices together with an additional comment line.
> Cc: Benjamin Herrenschmidt <>
> Signed-off-by: Andy Shevchenko <>

linux-nvme mailing list

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24  9:38 Andy Shevchenko
2020-02-24 10:55 ` Chaitanya Kulkarni [this message]
2020-02-24 17:13 ` Christoph Hellwig
2020-02-25 20:27 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on

Archives are clonable:
	git clone --mirror linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ \
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone