From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v1] nvme-pci: Move enumeration by class to be last in the table
Date: Mon, 24 Feb 2020 10:55:11 +0000 [thread overview]
Message-ID: <BYAPR04MB57492B2B9BDC41C0EC58810886EC0@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200224093823.17534-1-andriy.shevchenko@linux.intel.com
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 2/24/20 1:55 AM, Andy Shevchenko wrote:
> It's unusual that we have enumeration by class in the middle of the table.
> It might potentially be problematic in the future if we add another entry
> after it.
>
> So, move class matching entry to be the last in the ID table.
>
> While here, group Apple devices together with an additional comment line.
>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-24 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 9:38 [PATCH v1] nvme-pci: Move enumeration by class to be last in the table Andy Shevchenko
2020-02-24 10:55 ` Chaitanya Kulkarni [this message]
2020-02-24 17:13 ` Christoph Hellwig
2020-02-25 20:27 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57492B2B9BDC41C0EC58810886EC0@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).