Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] nvme: add error message on mismatching controller ids
@ 2019-11-21 17:58 James Smart
  2019-11-21 19:28 ` Ewan D. Milne
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: James Smart @ 2019-11-21 17:58 UTC (permalink / raw)
  To: linux-nvme; +Cc: James Smart

We've seen a few devices that return different controller
id's to the Fabric Connect command vs the Identify(controller)
command. It's currently hard to identify this failure by
existing error messages. It comes across as a (re)connect
attempt in the transport that fails with a -22 (-EINVAL)
status. The issue is compounded by older kernels not having
the controller id check or had the identify command overwrite
the fabrics controller id value before it checked. Both resulted
in cases where the devices appeared fine until more recent kernels.

Clarify the reject by adding an error message on controller
id mismatches.

Signed-off-by: James Smart <jsmart2021@gmail.com>
---
 drivers/nvme/host/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 9696404a6182..c272afb084d1 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2824,6 +2824,10 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
 		 * admin connect
 		 */
 		if (ctrl->cntlid != le16_to_cpu(id->cntlid)) {
+			dev_err(ctrl->device,
+				"Mismatching cntlid: Connect %u vs Identify "
+				"%u, rejecting\n",
+				ctrl->cntlid, le16_to_cpu(id->cntlid));
 			ret = -EINVAL;
 			goto out_free;
 		}
-- 
2.13.7


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 17:58 [PATCH] nvme: add error message on mismatching controller ids James Smart
2019-11-21 19:28 ` Ewan D. Milne
2019-11-21 20:16 ` Chaitanya Kulkarni
2019-11-22 14:40 ` Hannes Reinecke
2019-11-26 16:51 ` Christoph Hellwig
2019-11-26 17:39 ` Keith Busch

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git