From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "hch@lst.de" <hch@lst.de>, "Amit.Engel@Dell.com" <Amit.Engel@Dell.com>
Subject: Re: [PATCH] nvmet: fix per feat data len for get_feature
Date: Wed, 11 Dec 2019 05:09:15 +0000 [thread overview]
Message-ID: <BYAPR04MB574989BD16D14AD27C63C649865A0@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20191210072201.9631-1-chaitanya.kulkarni@wdc.com
On 12/09/2019 11:22 PM, Chaitanya Kulkarni wrote:
> From: Amit Engel <amit.engel@dell.com>
>
> From: Amit Engel <amit.engel@dell.com>
>
Seems like original author is added twice in this patch.
Should I send a separate patch to remove that ?
> The existing implementation for the get_feature admin-cmd does not
> use per-feature data len. This patch introduces a new helper function
> nvmet_feat_data_len(), which is used to calculate per feature data len.
> Right now we only set data len for fid 0x81 (NVME_FEAT_HOST_ID).
>
> Fixes: commit e9061c397839 ("nvmet: Remove the data_len field from the nvmet_req struct")
>
> Signed-off-by: Amit Engel <amit.engel@dell.com>
> [chaitanya.kulkarni@wdc.com:
> 1. Don't re-calculate cdw10 nvmet_get_feature(), that also fixes the
> endianness.
> 3. Rename nvmet_feature_data_len() -> nvmet_feat_data_len().
> 4. Get rid of the extra variable feature in nvmet_feat_data_len().
> 5. Mark nvmet_feat_data_len() staic since we are the only user.
> 6. Kernel patch style fixes.
> ]
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-11 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 7:22 [PATCH] nvmet: fix per feat data len for get_feature Chaitanya Kulkarni
2019-12-11 5:09 ` Chaitanya Kulkarni [this message]
2019-12-12 9:07 ` Christoph Hellwig
2019-12-12 9:14 ` Engel, Amit
2019-12-12 9:39 ` Christoph Hellwig
2019-12-12 9:40 ` Engel, Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB574989BD16D14AD27C63C649865A0@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Amit.Engel@Dell.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).