From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Jean Delvare <jdelvare@suse.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] nvme: Don't deter users from enabling hwmon support
Date: Tue, 11 Feb 2020 16:55:31 +0000 [thread overview]
Message-ID: <BYAPR04MB57499F5D62181577D815E3F986180@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200211134136.099ac9eb@endymion
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 02/11/2020 04:41 AM, Jean Delvare wrote:
> I see no good reason for the "If unsure, say N" advice in the
> description of the NVME_HWMON configuration option. It is not
> dangerous, it does not select any other option, and has a fairly low
> overhead.
>
> As the option is already not enabled by default, further suggesting
> hesitant users to not enable it is not useful anyway. Unlike some
> other options where the description alone may not be sufficient for
> users to make a decision, NVME_HWMON is pretty simple to grasp in my
> opinion, so just let the user do what they want.
>
> Signed-off-by: Jean Delvare<jdelvare@suse.de>
> Cc: Christoph Hellwig<hch@lst.de>
> Cc: Guenter Roeck<linux@roeck-us.net>
> Cc: Keith Busch<kbusch@kernel.org>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-11 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 12:41 [PATCH] nvme: Don't deter users from enabling hwmon support Jean Delvare
2020-02-11 13:30 ` Guenter Roeck
2020-02-11 16:55 ` Chaitanya Kulkarni [this message]
2020-02-11 20:43 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57499F5D62181577D815E3F986180@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=jdelvare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).