From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Keith Busch <keith.busch@intel.com>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v9 2/9] nvme: make nvme_identify_ns propagate errors back
Date: Fri, 30 Aug 2019 18:41:58 +0000 [thread overview]
Message-ID: <BYAPR04MB5749FFF1E5CF489B4D194DFE86BD0@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190829220645.5480-3-sagi@grimberg.me
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 08/29/2019 03:07 PM, Sagi Grimberg wrote:
> right now callers of nvme_identify_ns only know that it failed,
> but don't know why. Make nvme_identify_ns propagate the error back.
> Because nvme_submit_sync_cmd may return a positive status code, we
> make nvme_identify_ns receive the id by reference and return that
> status up the call chain.
>
> Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Reviewed-by: James Smart <james.smart@broadcom.com>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/host/core.c | 30 +++++++++++++-----------------
> 1 file changed, 13 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-08-30 18:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190829220645.5480-1-sagi@grimberg.me>
[not found] ` <20190829220645.5480-2-sagi@grimberg.me>
2019-08-30 18:39 ` [PATCH v9 1/9] nvme: fail cancelled commands with NVME_SC_HOST_PATH_ERROR Chaitanya Kulkarni
[not found] ` <20190829220645.5480-3-sagi@grimberg.me>
2019-08-30 18:41 ` Chaitanya Kulkarni [this message]
[not found] ` <20190829220645.5480-4-sagi@grimberg.me>
2019-08-30 18:45 ` [PATCH v9 3/9] nvme: make nvme_report_ns_ids propagate error back Chaitanya Kulkarni
[not found] ` <20190829220645.5480-7-sagi@grimberg.me>
2019-08-30 18:55 ` [PATCH v9 6/9] block_dev: split disk size check out of revalidate_disk Chaitanya Kulkarni
2019-09-09 6:59 ` Hannes Reinecke
[not found] ` <20190829220645.5480-8-sagi@grimberg.me>
2019-08-30 19:02 ` [PATCH v9 7/9] nvme: pass status to nvme_error_status Chaitanya Kulkarni
2019-08-30 19:08 ` Sagi Grimberg
2019-09-09 6:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB5749FFF1E5CF489B4D194DFE86BD0@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).