From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14538C433B4 for ; Wed, 14 Apr 2021 08:17:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B58B600EF for ; Wed, 14 Apr 2021 08:17:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B58B600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UMb8XIVAI2M16A0q/sUbC4KtRWLRxoLbtqlejSymxIY=; b=lJVPOuSFiecne+UeBibfDXOJ2 7pDuy+gEIdOt7a4gAnSaAeMiYlJXKpQ2uG7AKuO8KNpYkcGTfjDjxyCgSxMQVNZDm3d2iI31IsuzS PJeKnzUiJDyMWM0XtrRKmoZWi1x80P4pzEHQ6HYDj3Z/BX06eaAamfPu4YNkkGWF1gZ8w7wwOXSeo 8GIKSyomsCrquwK0Ck4T5b2P3vi0cdK3sa5nT1JKV+EWFBHLItipJhaOb/Kv1ZiM2jh6BPl4bZy56 DUJndleZbEija7O8UdNZNGvyMDqGJQ+F0lPIPSZKeBriAGoBEvGQPd2p2BHxYxmzTLu7Ojh4CcTg2 1CTjsVSmQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWahz-00BwtN-EK; Wed, 14 Apr 2021 08:17:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWaht-00Bwt5-T0 for linux-nvme@desiato.infradead.org; Wed, 14 Apr 2021 08:17:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=guBE4lkEGhFERwEkMT5c6BUu1AnJVztvUfsNwX07q80=; b=wc/BIXFRCXxfBcMeC1ebB4lN4/ WXAVRGV/EdYs0VRF71k+qno7SWotzLWQznh/2i/oVCq1xuv0cePgJ2WgkZtlieI2LF86OkK48krl5 FMpddzn1ArU5eijSbGfNv1pnRd5wQUlzZjYe+sP9QkcpaTlmFR1pnXZjHHZtOKEqXCtZuNjoCqTt0 7VqtVDYr8FSGLK+AxJq/OxT/WG1QsfftQzSLLvJhKlccTY0QmnClp+3JNVUbm6Hn0Dy/7fwD5GUkx 3daakItDlL4Ag+oxBgbqXqlT/9iN+evTocmbK3X1gE1eklse9a2LvR4SgRxUNayzt2kf0yIL/Sjqh kCWUm0Tg==; Received: from mail-bn8nam12on2068.outbound.protection.outlook.com ([40.107.237.68] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWahp-007bVw-5S for linux-nvme@lists.infradead.org; Wed, 14 Apr 2021 08:17:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QuKXfLnRaqOgNzL39vkEb6fbHRHnXFv10V6ijq2dndjzOvxDTcbX9EeNSdUH4tXqe3+sDl9+7BRuGt08ltMZCcF9EP51U7NypNv7/yVEaYarEBjvA+sTu3tUKAHd/5mz1dQ0hCs15aNu1N0sd+nOGcvBEoZJKj1Y6cs05QJG4sJJ5OfAFe0E1Ya335zJccIxxwYqIPgKWbkMF9BEGb88qgpMr0I/m+mx9N5G4KbgisWwmTo6muRXqh/KjusMV1NzDkFrrhDKaB1VFzg5GmhdGsT4Jw+cYhsZm/sjaWzstOZkWlB7CJ3+3Qubi9DC5jdtQrVgZiFxmUa/8A2Np2iuoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=guBE4lkEGhFERwEkMT5c6BUu1AnJVztvUfsNwX07q80=; b=GsK9mhl7uzqAbm2CNjeI4aat+aw22igjQ6G0lt1KKRG1S8jDtyNA5lEPep89yJjgDdD4yHT0cievf0MqaOWp9DtLOV0NqXnbWJhHWJP5CnO0DH5pBO/zUQi6880c25r2xx9A2XoVYkKSIpDqe0F24ZmrBx/8pjM5OxamIoEucconTNRKMbBOQ+mauK9HM2jeV7kx7zx8wHoe8EyTQ+vmw4CCEJyipS1IwdjHxThdWDdw5dCm4FHEsfatl1cHl2q5SJ1EhR6DLTLo80Wn/W8thSEJmGiUP1jEvLJO4dL1JoyHHyFr5YVmjVy8ltP40iTo/YvSVm1GT5av2LC+JJVNPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=guBE4lkEGhFERwEkMT5c6BUu1AnJVztvUfsNwX07q80=; b=NTgeK1UHSZRN5m6lgWukRdtF3Vlu5bXL9yTbS2yUqLa0oKfqF+PDxyNW+6bMFK+vDwHnXMoSfhf5VlwV1FKts5hrKQ7F2fSXfr8ePqFp2J1kPHqUR261QIw9rPjw0ofsj+rMLgjFVuQNTiz+K+dEOLygJfxxELmXuAmxUbovXD8= Received: from BYAPR12MB3238.namprd12.prod.outlook.com (2603:10b6:a03:13b::20) by BY5PR12MB4164.namprd12.prod.outlook.com (2603:10b6:a03:207::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Wed, 14 Apr 2021 08:16:57 +0000 Received: from BYAPR12MB3238.namprd12.prod.outlook.com ([fe80::5870:fcd6:b13a:c49c]) by BYAPR12MB3238.namprd12.prod.outlook.com ([fe80::5870:fcd6:b13a:c49c%5]) with mapi id 15.20.4020.023; Wed, 14 Apr 2021 08:16:56 +0000 From: "Liang, Prike" To: Greg KH CC: "linux-nvme@lists.infradead.org" , "kbusch@kernel.org" , "Chaitanya.Kulkarni@wdc.com" , "hch@infradead.org" , "S-k, Shyam-sundar" , "Deucher, Alexander" , "# 5 . 11+" Subject: RE: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume Thread-Topic: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume Thread-Index: AQHXMPZWugAdfwQ9zE+MP2pwxe1wgaqzj+0AgAAGbLCAAAz3gIAAB47w Date: Wed, 14 Apr 2021 08:16:56 +0000 Message-ID: References: <1618381200-14856-1-git-send-email-Prike.Liang@amd.com> <1618381200-14856-2-git-send-email-Prike.Liang@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=d412200b-bb3d-45b5-93a9-1976d907db43; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2021-04-14T08:16:08Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=amd.com; x-originating-ip: [180.167.199.182] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0bc19cf-0c50-4cf7-f827-08d8ff1dab74 x-ms-traffictypediagnostic: BY5PR12MB4164: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9YmwrCJH0jVRgnsERiIhn0/GtgsH9j/dqVpjV6qasWPKkrS7nDQAcII5vb6VZU6q4RiNyIEy+2X6G+A4IcEUmvMOzcZ7nH5qNvunAHnE7llqi4CCCHuQpZOji4iUSsM97WQMRQ6/Xuo3IvwBVqKZHcTB4P4pz7m+QRUA2VDxXg+waAG4SrC3HdOTQvVvmDhXvtDiMndz2Rpn6ZPOBf0NVtafqNh8tMdG5XaXFDeRJJIE0RlARR7BJFZ6ChtRCdqTV6oJ+BzWHzRknuOtkVme26iWL5HV0weQj05oK6n/VtVaOqA02WwIOaS5SZXc/ow7J/YJdgpVObP4VD+t8GmNis+uFNJurwRSMPwS1hiZIXIaypxbF+INyeKvMsiGLoUTIT+eRYoKMhX0tDQ/zPk48pTaISNwuAaqMgSb2pL5YbdNYUzIz/mETqfH9TJCX7lq4caNb01tfwKjToJJIS16m1aYhwwGrGw9hzX9gYOtNACjyDWkuCLiy57e+4r7fGyNtMsDZY4R/N6RqJtu1jM/MSnlAD2be8CjAXyJTG6C5w3plsRqJIPElu05EcRD+SKTUxk+hVrF+P3sN3o/zh7FEs9hTqq5j5P0nAEFCuGcNCg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3238.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39850400004)(376002)(366004)(346002)(186003)(66446008)(76116006)(66476007)(478600001)(66556008)(64756008)(8936002)(4326008)(9686003)(316002)(54906003)(7696005)(8676002)(83380400001)(26005)(38100700002)(2906002)(33656002)(55016002)(122000001)(15650500001)(6916009)(5660300002)(86362001)(6506007)(53546011)(52536014)(71200400001)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XeyHkizjVjSs8nzdQDd41W5ErQPND8XxEzL7nJIlNrJnzAYA2GKG+9u5liXA?= =?us-ascii?Q?YVY14MbdvfwQ+fhlm7zi347x33SQF05UpW1wrQcT2Zg9h34LIweiwCG8pgBl?= =?us-ascii?Q?FVn22wIP1oUQq3jx1nJa2j9Jh1TyDC2ylcHsbRlG3mYYBo+/HZ+Ivh/97rB0?= =?us-ascii?Q?dzd8lhaV0ZbKn6y15TsWAPisZW9Bz/kAvZPPVjReFr37xQZUNyuj5QeGXVDA?= =?us-ascii?Q?Iv6qt0Zy0VXU6VAPbm9WYMQiXhSvr8ecEFOK54GvPMBk3YcQstWspJd+bfzS?= =?us-ascii?Q?FQuufrJ7Nr8uJOrJECBUQH2njXG6wWmaBo4Gu10KEFnRwwePxLxJ0ujdU+7o?= =?us-ascii?Q?mupUA2ZLu7PShF6P6nwKkmSGkCr1VqI5inNkNKLfusHwh+oB2EvFAfD6ttiK?= =?us-ascii?Q?3y9gv6GkGvmEZBhct4alw2zoIPmYukTOgwyC5+1bl76Jfv803e+IhZSseTOM?= =?us-ascii?Q?w5OODepnv0nDJub9D4T40KcJpZpxij/WO8B65mcj02QpeQKsmZf05tZGufrv?= =?us-ascii?Q?H99C96NAi+V13GE8+r8EcJmGCFuurFJDQT8gmOdQKd8l7EGaB8N5YWSXc9XS?= =?us-ascii?Q?sqD1OHzjMaxmARFjivbPMfANYMxdaNGEidDEHh0GlHPvk84VPHarZ0XeYNKj?= =?us-ascii?Q?a9l1u29mPolfddtxFGF2KjVfJHefTJmP6YLf6AopjpSCNMwBLSq6/SXBWhKE?= =?us-ascii?Q?3jGsiVgSgb/zwem1l4xTsWbKWbXQ5uwrJfxY84hXAdGDj7leRyWBnpYDNDD+?= =?us-ascii?Q?BlCgZ6zOKotFAMrk//bY2wznJPZV9bU8JPXfsHHvGUPaKMRPpyy8iYa6FgQJ?= =?us-ascii?Q?u7ALLEqoPNmHgkbO5Jtzi6uuZNoC/zeHGOcdk8xODNDfLhtVTVvQI5zkGlsD?= =?us-ascii?Q?5RxvIRxmpl2m+fLGcfJvS7wrQ/e+hALGBOqOI8jCLS9zu7X7XPWmGruuHtN5?= =?us-ascii?Q?HITJyOc51NsZwHpYJIXsKrINVHnr0QIzWOzvjOLehZv6pvuoYLiHMJGVZshV?= =?us-ascii?Q?fheqzPY8A2XCAdTppoExe3QYoYqnoG45MFmmukBYzEB4iszPgdPSR8askbZX?= =?us-ascii?Q?8hLMtSbWxUbpTy8Xy15jPePIJgAOC1WROad45abRiqdyXsmt2HWU/Qfvl0rr?= =?us-ascii?Q?cMIxH4VQ0vS93yVuNN37tEqsrZgNR/6c79X3DO2qI56EfRskDP0JsLEtvn8r?= =?us-ascii?Q?4anz2bEhJEgmQ+aGArTcaD9ydK3SXmvxq3622eqwm3oQy7AmPi9Shb/rGHkR?= =?us-ascii?Q?F2VaWs7xdVkq2C/QndA80FoycgvH0FjgYtgTWQYb43BdMp549T0KGIyswkue?= =?us-ascii?Q?QHnqBvBE4LLyLADLRGXSWXVF?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3238.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0bc19cf-0c50-4cf7-f827-08d8ff1dab74 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 08:16:56.6340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NDCjc1EJ3kcy0UttflnYMg5V5G/VboL4nkiQ4bViXiXu5KPT7W/5cP4d4OHd7SOR X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4164 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_011701_961450_9FA311A6 X-CRM114-Status: GOOD ( 27.42 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org [AMD Public Use] > From: Greg KH > Sent: Wednesday, April 14, 2021 3:49 PM > To: Liang, Prike > Cc: linux-nvme@lists.infradead.org; kbusch@kernel.org; > Chaitanya.Kulkarni@wdc.com; hch@infradead.org; S-k, Shyam-sundar > ; Deucher, Alexander > ; # 5 . 11+ > Subject: Re: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume > > On Wed, Apr 14, 2021 at 07:13:15AM +0000, Liang, Prike wrote: > > [AMD Public Use] > > > > > From: Greg KH > > > Sent: Wednesday, April 14, 2021 2:40 PM > > > To: Liang, Prike > > > Cc: linux-nvme@lists.infradead.org; kbusch@kernel.org; > > > Chaitanya.Kulkarni@wdc.com; hch@infradead.org; S-k, Shyam-sundar > > > ; Deucher, Alexander > > > ; # 5 . 11+ > > > Subject: Re: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for > > > suspend/resume > > > > > > On Wed, Apr 14, 2021 at 02:20:00PM +0800, Prike Liang wrote: > > > > The NVME device pluged in some AMD PCIE root port will resume > > > > timeout from s2idle which caused by NVME power CFG lost in the SMU > FW restore. > > > > This issue can be workaround by using PCIe power set with simple > > > > suspend/resume process path instead of APST. In the onwards ASIC > > > > will try do the NVME shutdown save and restore in the BIOS and > > > > still need PCIe power setting to resume from RTD3 for s2idle. > > > > > > > > Update the nvme_acpi_storage_d3() _with previously added quirk. > > > > > > > > Signed-off-by: Chaitanya Kulkarni > > > > [ck: split patches for nvme and pcie] > > > > Signed-off-by: Prike Liang > > > > Signed-off-by: Shyam Sundar S K > > > > Reviewed-by: Chaitanya Kulkarni > > > > Cc: # 5.11+ > > > > --- > > > > drivers/nvme/host/pci.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > > > index > > > > 6bad4d4..5a9a192 100644 > > > > --- a/drivers/nvme/host/pci.c > > > > +++ b/drivers/nvme/host/pci.c > > > > @@ -2832,6 +2832,7 @@ static bool nvme_acpi_storage_d3(struct > > > > pci_dev > > > > *dev) { > > > > struct acpi_device *adev; > > > > struct pci_dev *root; > > > > +struct pci_dev *rdev; > > > > acpi_handle handle; > > > > acpi_status status; > > > > u8 val; > > > > @@ -2845,6 +2846,10 @@ static bool nvme_acpi_storage_d3(struct > > > pci_dev *dev) > > > > if (!root) > > > > return false; > > > > > > > > +rdev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0)); if > > > > +(rdev && (rdev->dev_flags & > > > PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND)) > > > > +return NVME_QUIRK_SIMPLE_SUSPEND; > > > > + > > > > adev = ACPI_COMPANION(&root->dev); if (!adev) return false; > > > > -- > > > > 2.7.4 > > > > > > > > > > This is still broken, why resend it? > > Sorry can't get how come the reference count leaked, could you help give > more detail about this. > > Please read the documentation for the call you are making here. For once, it > is actually written down what needs to be done :) Thanks, get it now and will update the patch. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme