From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F7DC433B4 for ; Thu, 15 Apr 2021 03:23:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13CEC60E0B for ; Thu, 15 Apr 2021 03:23:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13CEC60E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=abnsGdBDbfHEao5Xmc/2VeT6xUyBwuvSoMQq8cetcSE=; b=nHB8j9In+OoM6N/TAw8FdPL30 eK2M1EUYJy0RbmEXGi4xDcnJhu0dG7BUj8yGttfNIZK1raM4OwpPqFEA6zngaJJqIs3TS8rtl0gu5 NdQLJiwLJq32jDS4AJzwmt4rY6LDm/+90qbqaqX9LtpTZukZzH3LmK2tClSAWJJO7KfLNgy7J2801 +UEqln6t4ZWU4VEd7EX1z5829W+CJRuxjp4J5Y/DdaftLkg9d2vBF7rNdq61sJJBNECXY+dhKFRRu ppVfUDTIMOg/NScxow2OIi6nNhU2Zirk1JH/nLcANK+XwwBmCid2nKLVl6SxPXS5tN1AWtzzrwwgE wMHuvTgxw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWsbJ-00EdCo-Ir; Thu, 15 Apr 2021 03:23:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWsaz-00EdC6-2V for linux-nvme@desiato.infradead.org; Thu, 15 Apr 2021 03:23:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=BZGEBqsg800u7DgKV02JTKh/h9ksXDQDxcBhd0Qt4rM=; b=SMJm4fgBEJpxyunZZyto3XP2sH /OPV+Bgbebrix63O6nKXfMlX63tWctxaRKtz66fZqp4QRKaUIq22QgDQRzsk0pgmFF5ZnBkR3jdc7 bQCv5hf8iFcMPkymVWMnCZ35X5TuRrLSfUSdXY9B+KSyC/aZpk82sEJnHYTzrpPtLYFKtCYgykuaR BqPU5HVWk/Du3MtbzHE4AFT4kvKUAyta6q2AXDAdPOR53aEeh+M/DdZGKiRibdzfhvnd6if+GZjwF ONunKCXc1GH9/Nl6EsPfi2iKpuzgT8Nec6nmaptxRQShRD7W1wOP/j7BYUsDLoVxTjHTJTRlgMvzO THXKWPFQ==; Received: from mail-dm6nam10on2065.outbound.protection.outlook.com ([40.107.93.65] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWsav-008EWV-1z for linux-nvme@lists.infradead.org; Thu, 15 Apr 2021 03:23:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KWEeG7k/y5yQz4R2G19D7OeuJn2eAmUOiJS9oMgrNCd77OZ+q6aMXZmo8Emy+y+O7o2hA3WoNTx/6KYNYIHy3FIX7DZTUitU7FXYUP2FkcQ3OEC9aCbgEQqyIiGkHjtMV3t8ULtzC7PNg9PCQoHCF7U48ZfuxXNnnYxyRhWz1vxWTo9iW3DfOrVLiCQznA1vlbwc/VuuMtgVsI6pzE/jnh/NnzlWyLaEJthF/378hbBydWWkKjjQB1b+J2MRh6b7y3SOQXoUbK18lywEtBv9JQMiy1fona/mL79dg5GHt2wPh0C+1eBp+mdlG3Ve2EwhGchCFdiVC9UdpxoW5z4uMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZGEBqsg800u7DgKV02JTKh/h9ksXDQDxcBhd0Qt4rM=; b=W/DfNIMwhdT1cl7KSH9pXn+qoYCQhuRcZ/TbX0Lc4yztycI10wDN50mX5OmbygrI0TYc/SndiG+cKiTCMTib5b5cq48QqYYtbEW2ug9PpUa5sdD5xUjZYPXWoAH5k5Ja01mpX/KGfwr2Rzu2vawff+VFKe9m1kwk7f3ygx9Ot6F6q5iFQpw6/F/jDEiT1MkK15kYU/IE07lO2xOVnWOaAoZg6zR778O7Riu9f+vsMCOjAykXN3Pade/cEBzLyj5Tjgb6b0QojCBs+vZeWE4hsWM/BUszKM3m5hgtzUc+6OXpibSsqljipgzpgX/4gzx6VGNTqFimxdRyAVb5OmkgSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZGEBqsg800u7DgKV02JTKh/h9ksXDQDxcBhd0Qt4rM=; b=wM63O6+ZS77eVMAYUziDBenGFFapdz6EnGA+tPM9qW5pmsjBp7YYKEcRdHLYhx4xZxA82C5jnikJtVk74jNB7uZ9ytaGE9uU8BUQxPPEPvda+VVuMX14773wkcCmXuBu6XQIznsQLGTg0RXKwYW3xY73ekftWCAbsHtYCOk7OQ8= Received: from BYAPR12MB3238.namprd12.prod.outlook.com (2603:10b6:a03:13b::20) by BY5PR12MB3650.namprd12.prod.outlook.com (2603:10b6:a03:1a3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 03:22:53 +0000 Received: from BYAPR12MB3238.namprd12.prod.outlook.com ([fe80::5870:fcd6:b13a:c49c]) by BYAPR12MB3238.namprd12.prod.outlook.com ([fe80::5870:fcd6:b13a:c49c%5]) with mapi id 15.20.4020.023; Thu, 15 Apr 2021 03:22:52 +0000 From: "Liang, Prike" To: Keith Busch CC: "linux-nvme@lists.infradead.org" , "Chaitanya.Kulkarni@wdc.com" , "gregkh@linuxfoundation.org" , "hch@infradead.org" , "stable@vger.kernel.org" , "S-k, Shyam-sundar" , "Deucher, Alexander" Subject: RE: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume Thread-Topic: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume Thread-Index: AQHXMQbUyHYou0SCfUyu35B/FPG9paq0MyIAgACQ74A= Date: Thu, 15 Apr 2021 03:22:52 +0000 Message-ID: References: <1618388281-15629-1-git-send-email-Prike.Liang@amd.com> <1618388281-15629-2-git-send-email-Prike.Liang@amd.com> <20210414162408.GC2448507@dhcp-10-100-145-180.wdc.com> In-Reply-To: <20210414162408.GC2448507@dhcp-10-100-145-180.wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=33a7fdf7-c4e0-4d4f-9311-8f9e6d3516b7; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2021-04-15T01:03:07Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=amd.com; x-originating-ip: [139.227.235.92] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5982a2c7-327d-4f5a-6e55-08d8ffbdc128 x-ms-traffictypediagnostic: BY5PR12MB3650: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ifv0pNl4KvxHuCgD9MTmE8s/h6ESpFMdR6+LyuxGM2DMjkaaq5nVmBYrlPdmEhMMUcQwovJECWVUmI4p2YLyZcg2tkXy6m/u2zCqt9WrD3a6ckPji/GDyxyg8Fma9I03ckxvUEXZn/vyFHWmM7PpHuRugt6l+bGegkX59VP0zjZTDMjdsZgKFaAClKft6Ap4m6QLZjOHUNLtMS+jhiTI5g/wk+Vm/miqj5QrMxRVRcOMJXxyeflbyyP7dG+K5rj+HYVaTFsN2e+RDW8Wpyy+2hv43Akduh+fFVQ5k8Wb45bEgjO+Xs88ZwcgqcX7SOv7EssqdOe5zUBms5GP05/u9W8RUnZnUXpjtsgJeaF0HF05xbn6t4UTLAerEk4N915Bnh3YGEQQxkTEebvHQGVfwix1ReevmzH2TPldZzcnHMXPozea+j3HKGs10gEfbfP5W+W0XHLK0ov9bREF+J105fhLVPC2tYEbj+hnz4qrxqW1aA2ynX7uz3Y3ZVAxQtDD02VEYoou+EDSpZg+snSEBM273lrUh7wimZ5js0l70lwbhkpxCoy3hC5RN8XFm2+i3wrtJ4FDF3hui0iibk29d953iRpXcha04oPRi2HzOJE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3238.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(9686003)(122000001)(83380400001)(8936002)(86362001)(4326008)(6506007)(66946007)(76116006)(6916009)(478600001)(53546011)(54906003)(2906002)(66446008)(64756008)(66556008)(66476007)(15650500001)(55016002)(71200400001)(316002)(52536014)(7696005)(8676002)(5660300002)(26005)(38100700002)(186003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3a85kVSUl8Rq5RV7JPOqewlfPaXZK9t8SbGGGfLmozA6ZYoMYRJtdUbwHB5E?= =?us-ascii?Q?1jWekKa2wzlu7XouUQ2JjYXtil2ET1I12xv1V3ItQHFVJU93cFBHokl6m1X5?= =?us-ascii?Q?wGm3F+QcyadVJ41L7b7VEGtfP7O1idgsdyP3+qODavsArx9xTEa8PPZcYRNi?= =?us-ascii?Q?wRNhfIOvKid3ckdRWX3TAyNtowA1ShW6i2MLRAtG9RySpraJH5BuZZAILjXA?= =?us-ascii?Q?9yi1ANBFareaOhqEkifkfJX/yo3k0Rz9hY8389ULCfkAxmmyRZaHSRfc5Loa?= =?us-ascii?Q?RvkAnCXXUGoM/Mi+kwG+0Vin1UnbqWIsbwFz/bfqIPxoPlRI/6CsD2K5gm/d?= =?us-ascii?Q?fVJqF/japleW/YRZgVQtuAfUKfmvRcMXpXYpaeDQzS23lC3JPWZ+hY48kpN3?= =?us-ascii?Q?rwqm80ctgqq6FBMiBVdKvvxF9JlzQiZDaw+KnswGcg1l/Os3MD+PZSKPhVwN?= =?us-ascii?Q?MV0kvIoujR+7bBRwldDtRyHSW1CyoqB41hh92cXFyIhouV91v/o3JPQEkEvc?= =?us-ascii?Q?AFsiZHGDA97rsCR9KuPimDwvHAxPfRNXvnvysbH5BfBHdGUpb4mY9vr4hirg?= =?us-ascii?Q?4vlDflaOvUYXvnbp7mgSRs+/yzd2oCTCoAnUxXlNqXOwqOUKvSnyWdDsD/S4?= =?us-ascii?Q?lIPWq5lOFo5mHny6iFyc/gLBjp58AzWX2/0dFui1BYgJSLZfJUyXp7Fengat?= =?us-ascii?Q?v+FSF5a7M/5u+n+GW6M7YDrBZoRKO15xyAGI3bFAotDSIfHENuWhVa9L517A?= =?us-ascii?Q?UseUEwnp4f56GVTscQfvZXlIusCTdLrtCI1H6CyZbGF6Wx0aF2Gid7WoJNRC?= =?us-ascii?Q?RzsfuwNq67nVRZ0nTYq22sp15EkfLhV5k2A2TDhULWCfHdXbx7JhxQiPCU/Y?= =?us-ascii?Q?8bHC4cS9b3QFw+PDkX0c4ukMjaSVhbznJb1LZb5Cg0qGgr8lEc9ou8mD6R9b?= =?us-ascii?Q?xvsYYpAez9o9Lzy5Wx1Ba3aoowx+hdr83s+7DmU4qowUhpToA2NoXgEzjCuT?= =?us-ascii?Q?TyaNnurF4/oV8Wdi8WtreGCU4QqmDlGvl6Bc4VBHOuf8i+3XXQwUKjQoxIqz?= =?us-ascii?Q?cLbqya3xhDT/WNe9cst4e+cAqK+e4qsdjJRDhUvv5E40FnG9F1tXeDtXCBRz?= =?us-ascii?Q?xysaenY/XXsE+2FhN4TIBsTKnaoXDHpkjEPUEaeXkb0z5tD2hlCmQWDVC6Fi?= =?us-ascii?Q?4LSWBM2YTYd2xCsZvUaMJP8itjL97Nxn8KCR7KTKgfYhiIiVOsn5qk6JuyKn?= =?us-ascii?Q?6SqBxFLNGk2PG7fY2yGBgTsZNCb2Tr/6kWNYHArSLtq8xPmbRrcwPu3ErvgJ?= =?us-ascii?Q?O1SVo/TqwucLNwv00hPp4duN?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3238.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5982a2c7-327d-4f5a-6e55-08d8ffbdc128 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 03:22:52.5340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y9eqcthDFoHExPDcs1ANmGlMKP63z90YSjd9eGkbiIPfvED3/0QDBcLoHbqVWEiN X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3650 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_202305_201738_EEB229FB X-CRM114-Status: GOOD ( 24.30 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org [AMD Public Use] > From: Keith Busch > Sent: Thursday, April 15, 2021 12:24 AM > To: Liang, Prike > Cc: linux-nvme@lists.infradead.org; Chaitanya.Kulkarni@wdc.com; > gregkh@linuxfoundation.org; hch@infradead.org; stable@vger.kernel.org; S- > k, Shyam-sundar ; Deucher, Alexander > > Subject: Re: [PATCH 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume > > On Wed, Apr 14, 2021 at 04:18:01PM +0800, Prike Liang wrote: > > The NVME device pluged in some AMD PCIE root port will resume timeout > > from s2idle which caused by NVME power CFG lost in the SMU FW restore. > > This issue can be workaround by using PCIe power set with simple > > suspend/resume process path instead of APST. In the onwards ASIC will > > try do the NVME shutdown save and restore in the BIOS and still need > > PCIe power setting to resume from RTD3 for s2idle. > > > > Update the nvme_acpi_storage_d3() _with previously added quirk. > > > > Signed-off-by: Chaitanya Kulkarni > > [ck: split patches for nvme and pcie] > > Chaitanya's Sign-off should be under the annotation explaining what he > changed, and placed below the original author's sign-off. > > > Signed-off-by: Prike Liang > > Signed-off-by: Shyam Sundar S K > > Reviewed-by: Chaitanya Kulkarni > > Cc: # 5.11+ > > --- > > It doesn't appear that you're reading Greg's autobot reply. This spot right > here is where you should describe what is different about this patch > compared to your previous versions. > Thanks proposal and will update the author info and patch version. > > drivers/nvme/host/pci.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index > > 6bad4d4..ce9f42b 100644 > > --- a/drivers/nvme/host/pci.c > > +++ b/drivers/nvme/host/pci.c > > @@ -2832,6 +2832,7 @@ static bool nvme_acpi_storage_d3(struct pci_dev > > *dev) { > > struct acpi_device *adev; > > struct pci_dev *root; > > +struct pci_dev *rdev; > > acpi_handle handle; > > acpi_status status; > > u8 val; > > @@ -2845,6 +2846,12 @@ static bool nvme_acpi_storage_d3(struct > pci_dev *dev) > > if (!root) > > return false; > > > > +rdev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0)); > > Instead of assuming '0', shouldn't you use the domain of the NVMe PCI > device? Now we just add the NVMe shutdown quirk by checking the root complex ID instead of adding more and more variables endpoint NVMe device. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme