linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries
@ 2021-07-31  8:32 koos vriezen
  2021-08-02 15:56 ` Keith Busch
  2021-10-14  2:04 ` Keith Busch
  0 siblings, 2 replies; 4+ messages in thread
From: koos vriezen @ 2021-07-31  8:32 UTC (permalink / raw)
  To: linux-nvme

Hi,

On my XPS 13 9380 I get local mails with content

"
The following warning/error was logged by the smartd daemon:

Device: /dev/nvme0, number of Error Log entries increased from 28 to 29

Device info:
PM981 NVMe Samsung 512GB, S/N:S3ZHNF0KB11472, FW:EXA74D1Q, 512 GB
"

after boot and increasing numbers after resume. Git bisect report:

git bisect start
# good: [9f4ad9e425a1d3b6a34617b8ea226d56a119a717] Linux 5.12
git bisect good 9f4ad9e425a1d3b6a34617b8ea226d56a119a717
# bad: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13
git bisect bad 62fb9874f5da54fdb243003b386128037319b219
# bad: [85f3f17b5db2dd9f8a094a0ddc665555135afd22] Merge branch
'md-fixes' of https://git.kernel.org/pub/scm/linux/kernel/git/song/
md into block-5.13
git bisect bad 85f3f17b5db2dd9f8a094a0ddc665555135afd22
# good: [ca62e9090d229926f43f20291bb44d67897baab7] Merge tag
'regulator-v5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/br
oonie/regulator
git bisect good ca62e9090d229926f43f20291bb44d67897baab7
# good: [68a32ba14177d4a21c4a9a941cf1d7aea86d436f] Merge tag
'drm-next-2021-04-28' of git://anongit.freedesktop.org/drm/drm
git bisect good 68a32ba14177d4a21c4a9a941cf1d7aea86d436f
# bad: [be18cd1fcae2ed7db58d92d20733dfa8aa0a5173] Merge tag
'mmc-v5.13' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
git bisect bad be18cd1fcae2ed7db58d92d20733dfa8aa0a5173
# bad: [fc0586062816559defb14c947319ef8c4c326fb3] Merge tag
'for-5.13/drivers-2021-04-27' of git://git.kernel.dk/linux-block
git bisect bad fc0586062816559defb14c947319ef8c4c326fb3
# good: [42dec9a936e7696bea1f27d3c5a0068cd9aa95fd] Merge tag
'perf-core-2021-04-28' of git://git.kernel.org/pub/scm/linux/kernel/g
it/tip/tip
git bisect good 42dec9a936e7696bea1f27d3c5a0068cd9aa95fd
# bad: [2958a995edc94654df690318df7b9b49e5a3ef88] block/rnbd-clt:
Support polling mode for IO latency optimization
git bisect bad 2958a995edc94654df690318df7b9b49e5a3ef88
# bad: [b60b270b3db617811e593db5d5920ed98e67ce49] swim3: support highmem
git bisect bad b60b270b3db617811e593db5d5920ed98e67ce49
# good: [de5878048e11f1ec44164ebb8994de132074367a] nvmet: remove
unnecessary ctrl parameter
git bisect good de5878048e11f1ec44164ebb8994de132074367a
# bad: [5befc7c26e5a98cd49789fb1beb52c62bd472dba] nvme: implement
non-mdts command limits
git bisect bad 5befc7c26e5a98cd49789fb1beb52c62bd472dba
# good: [d8e7b462f5b8b93920c6c6a191be887b32306e6b] nvmet-tcp: enable
optional queue idle period tracking
git bisect good d8e7b462f5b8b93920c6c6a191be887b32306e6b
# good: [25a64e4e7ef6da605a86ec1bff18d2c3c6ed5329] nvme: remove
superfluous else in nvme_ctrl_loss_tmo_store
git bisect good 25a64e4e7ef6da605a86ec1bff18d2c3c6ed5329
# good: [dd8f7fa908f66dd44abcd83cbb50410524b9f8ef] nvme: retrigger ANA
log update if group descriptor isn't found
git bisect good dd8f7fa908f66dd44abcd83cbb50410524b9f8ef
# good: [c881a23fb6f7eb901155d25ba8dd1af0b8c7923b] nvme: disallow
passthru cmd from targeting a nsid != nsid of the block dev
git bisect good c881a23fb6f7eb901155d25ba8dd1af0b8c7923b
# first bad commit: [5befc7c26e5a98cd49789fb1beb52c62bd472dba] nvme:
implement non-mdts command limits

Reverted 5befc7c26e (first 8609c63fce nvme: fix handling of large MDTS
values) on 5.13.6 I don't see the error anymore.


Best regards,

Koos Vriezen

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries
  2021-07-31  8:32 bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries koos vriezen
@ 2021-08-02 15:56 ` Keith Busch
  2021-08-02 16:49   ` koos vriezen
  2021-10-14  2:04 ` Keith Busch
  1 sibling, 1 reply; 4+ messages in thread
From: Keith Busch @ 2021-08-02 15:56 UTC (permalink / raw)
  To: koos vriezen; +Cc: linux-nvme

On Sat, Jul 31, 2021 at 10:32:20AM +0200, koos vriezen wrote:
> Hi,
> 
> On my XPS 13 9380 I get local mails with content
> 
> "
> The following warning/error was logged by the smartd daemon:
> 
> Device: /dev/nvme0, number of Error Log entries increased from 28 to 29
> 
> Device info:
> PM981 NVMe Samsung 512GB, S/N:S3ZHNF0KB11472, FW:EXA74D1Q, 512 GB
> "
> 
> after boot and increasing numbers after resume. Git bisect report:

The controller shouldn't log an error when we request an optional
identification. We don't have another way to determine if the controller
supports this other than to request it. I think this should be reported
to the device vendor for a firmware fix.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries
  2021-08-02 15:56 ` Keith Busch
@ 2021-08-02 16:49   ` koos vriezen
  0 siblings, 0 replies; 4+ messages in thread
From: koos vriezen @ 2021-08-02 16:49 UTC (permalink / raw)
  To: Keith Busch; +Cc: linux-nvme

Hi,

Op ma 2 aug. 2021 om 17:56 schreef Keith Busch <kbusch@kernel.org>:
>
> On Sat, Jul 31, 2021 at 10:32:20AM +0200, koos vriezen wrote:
> > Hi,
> >
> > On my XPS 13 9380 I get local mails with content
> >
> > "
> > The following warning/error was logged by the smartd daemon:
> >
> > Device: /dev/nvme0, number of Error Log entries increased from 28 to 29
> >
> > Device info:
> > PM981 NVMe Samsung 512GB, S/N:S3ZHNF0KB11472, FW:EXA74D1Q, 512 GB
> > "
> >
> > after boot and increasing numbers after resume. Git bisect report:
>
> The controller shouldn't log an error when we request an optional
> identification. We don't have another way to determine if the controller
> supports this other than to request it. I think this should be reported
> to the device vendor for a firmware fix.

Thanks for your answer. I have the latest Dell bios installed (which
applied quite some firmware updates as well during install -- not that
I remembered which one exactly) and officially this device is too old
for support from Dell.

I didn't see any recents hits with google for this error, so maybe
it's just this device. I guess I can add a `return 0;`  just before
the `nvme_ctrl_limited_cns` call in `nvme_init_non_mdts_limits`
locally for now.

Cheers,
Koos Vriezen

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries
  2021-07-31  8:32 bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries koos vriezen
  2021-08-02 15:56 ` Keith Busch
@ 2021-10-14  2:04 ` Keith Busch
  1 sibling, 0 replies; 4+ messages in thread
From: Keith Busch @ 2021-10-14  2:04 UTC (permalink / raw)
  To: koos vriezen; +Cc: linux-nvme

On Sat, Jul 31, 2021 at 10:32:20AM +0200, koos vriezen wrote:
> Hi,
> 
> On my XPS 13 9380 I get local mails with content
> 
> "
> The following warning/error was logged by the smartd daemon:
> 
> Device: /dev/nvme0, number of Error Log entries increased from 28 to 29
> 
> Device info:
> PM981 NVMe Samsung 512GB, S/N:S3ZHNF0KB11472, FW:EXA74D1Q, 512 GB
> "

Your nvme controller is too pedantic about logging errors. This is a
completely harmless host side request: the host doesn't know if the
Identify CNS is supported without trying it first. There's nothing
useful about this event that requires an error log entry, even though
the controller is allowed to do it.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-14  2:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31  8:32 bisected: 5befc7c26e nvme impl non-mdts gives smartd error log entries koos vriezen
2021-08-02 15:56 ` Keith Busch
2021-08-02 16:49   ` koos vriezen
2021-10-14  2:04 ` Keith Busch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).